This fixes a long-standing logic error that hasn't been noticed because
we never announced the rsa_pss_pss_sha{256,384,512} SignatureScheme. The
EVP_PKEY_id() of a RSA-PSS pubkey is EVP_PKEY_RSA_PSS, not EVP_PKEY_RSA.
Thanks to beck for helping me figure out how to fix this correctly. It
drove me nuts for a very long time. Problem also noticed by Tom Lane
due to some PostgreSQL regress failures.
ok djm jsing kenjiro
Multicast timers are protected by poper locks. The shortcut that
avoids locking when no timers are scheduled, does not need an
additional membar.
OK mvs@
Editing files on tmpfs uses nanotime() to update mtime, and touch uses
utimensat(UTIME_NOW) which uses getnanotime() which is cached and which
can be smaller.
So, sed ... A && touch B leads to mtime(A) > mtime(B) which isn't excted.
"Yep" deraadt@
This looks like a NULL dereference that should crash, but for some reason
it doesn't, even with -O0 with all compilers i tried. At the very least it
may result in compilers deducing that key_768 != NULL and lead to incorrect
optimizations.
ok claudio jsing kenjiro miod
The users of this code are single threaded today. The locks also
don't look to fully protect key state in qcow images. If/when virtio
block emulation ends up with multiple virtqueues, this will need
to be revisited.
ok mlarkin@, hshoexer@
This will contain defines and macros that we need for assembly code,
without polluting other headers that are primarily used for C code.
For now, this just unconditionally provides _CET_ENDBR on amd64.
ok kenjiro@ tb@
The API to look up a cert by subject or issuer name clearly only needs to
do name comparisons in a collection of certs so should by all means take a
const X509_NAME * as an argument. However, this isn't all that easy to do
and hence it's only in OpenSSL 4 that this obvious step was reached.
This means that there is no way around casting for older code. One could
cast the return value of X509_get_issuer_name() or the argument passed to
the two lookups by subject. jsing slightly prefers the second approach,
so this is what we do here.
ok djm jsing kenjiro
After the const sprinkling in OpenSSL 1.1, X509_get_{issuer,subject}_name()
still returned a non-const pointer for unclear reasons. In OpenSSL 4,
the return value also grew a const qualifier, so move the two "name" in
tls_conninfo.c and the "subject_name" in tls_verify.c to const. They are
only used for further processing by already const correct functions (at
least as far as X509_NAME is concerned).
ok djm jsing kenjiro
wcwidth(3) doesn't return the correct result for the NUL wide character.
Fix this by special casing the check for this value.
Interestingly our man page documents this special case explicitly, but it
looks like the function was broken in rev 1.2 from 2011 when support for
non-printable characters was added.
Flagged by Sortix os-test.
ok stsp@
With process accouting, nfsd(8) complains about unveil(2) violations.
It happens during daemon(3) in the child process. Instead of
unveiling / and /dev/null, move unveil(2) after daemon(3).
OK deraadt@
option has incorrect dates, let's recognize that this is no longer a good
way to get time information and only the ntp interface is needed.
ok sthen florian henning
with PTHREAD_MUTEX_INITIALIZER but not used.
Unify handling of mutexp == NULL in both version of pthread_mutex_destroy()
and ensure that *mutexp == NULL is not considered an error.
Problem found by tb@ with rpki-client.
OK kettenis@ tb@
POSIX says that sys/mman.h should also define mode_t which is currently
missing.
With mode_t defined there, the type of the last parameter of the shm_open
function can be changed from __mode_t to mode_t, matching the standard.
Both issues flagged by Sortix os-test.
ok deraadt@, millert@
If MIMO is disabled we must not try to configure Tx rates in firmware
which require MIMO. Otherwise we trigger sysassert 0x20101A0D.
Problem reported and fix tested by Kirill Kaplin.
Meaning of sysassert hex code provided by Johannes Berg, thanks!
