openbsd/src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2026-04-18 19:24:43 +00:00
Code Issues Projects Releases Wiki Activity

A binary without a PT_LOAD exec segment would later read a pinsyscall table

Browse Source 
and damage it strangely.  Such a binary cannot actually run, but we should
avoid the internal pinsyscall table damage, and fail the execve with EINVAL.
reported by Stuart Thomas
ok guenther
This commit is contained in:
deraadt
2026-04-11 16:12:40 +00:00
parent 54f7a0c00a
commit de62a587e2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sys/kern/exec_elf.c
View File

@@ -1,4 +1,4 @@
/* $OpenBSD: exec_elf.c,v 1.195 2026/02/09 21:58:27 deraadt Exp $ */
/* $OpenBSD: exec_elf.c,v 1.196 2026/04/11 16:12:40 deraadt Exp $ */
/*
* Copyright (c) 1996 Per Fogelstrom
@@ -551,7 +551,7 @@ elf_load_file(struct proc *p, char *path, struct exec_package *epp,
}
}
if (syscall_ph) {
if (syscall_ph && text_start != -1) {
struct process *pr = p->p_p;
vaddr_t base = pos;
size_t len = text_end;
@@ -569,7 +569,7 @@ elf_load_file(struct proc *p, char *path, struct exec_package *epp,
pr->ps_pin.pn_npins = npins;
}
} else {
error = EINVAL; /* no pin table */
error = EINVAL; /* nothing executable or no pin table */
goto bad1;
}