openbsd/src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2026-04-16 02:04:12 +00:00
Code Issues Projects Releases Wiki Activity

Error with EISDIR when calling open(2) with O_CREAT when the

Browse Source 
last component of the path is an existing directory and O_DIRECTORY
is not specified.

This is required by recent versions of POSIX.  We previously did
not return an error.

Flagged by Sortix os-test.

committing on behalf of daniel@, partly based on FreeBSD changes
ok guenther@ jsg@ deraadt@
This commit is contained in:
jsg
2026-04-08 12:08:25 +00:00
parent 8595ae99f9
commit 6e2242fc93
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/libc/sys/open.2
View File

@@ -1,4 +1,4 @@
.\" $OpenBSD: open.2,v 1.57 2026/04/08 11:36:40 jsg Exp $
.\" $OpenBSD: open.2,v 1.58 2026/04/08 12:08:25 jsg Exp $
.\" $NetBSD: open.2,v 1.8 1995/02/27 12:35:14 cgd Exp $
.\"
.\" Copyright (c) 1980, 1991, 1993
@@ -297,6 +297,16 @@ flag was specified and the target is a symbolic link.
.It Bq Er EISDIR
The named file is a directory, and the arguments specify
it is to be opened for writing.
.It Bq Er EISDIR
The named file is a directory, and the flags specified
.Dv O_CREAT
without
.Dv O_DIRECTORY .
If
.Dv O_EXCL
is also specified, see
.Er EEXIST
which is returned instead.
.It Bq Er EINVAL
The
.Fa flags

6
sys/kern/vfs_vnops.c
View File

@@ -1,4 +1,4 @@
/* $OpenBSD: vfs_vnops.c,v 1.126 2026/04/08 11:32:24 jsg Exp $ */
/* $OpenBSD: vfs_vnops.c,v 1.127 2026/04/08 12:08:25 jsg Exp $ */
/* $NetBSD: vfs_vnops.c,v 1.20 1996/02/04 02:18:41 christos Exp $ */
/*
@@ -134,6 +134,10 @@ vn_open(struct nameidata *ndp, int fmode, int cmode)
error = EEXIST;
goto bad;
}
if (vp->v_type == VDIR) {
error = EISDIR;
goto bad;
}
fmode &= ~O_CREAT;
}
} else {