1
0
mirror of https://github.com/openbsd/src.git synced 2026-04-15 01:34:03 +00:00

Do the unveil() after the daemon() call, because otherwise we wouldneed

"/dev/null" "rw" and "/" "r", in particular the second is ugly.
pointed out by bluhm, discussion also with dgl.
This commit is contained in:
deraadt
2026-04-01 15:39:05 +00:00
parent 0d123a3a59
commit 471a995e78

View File

@@ -1,4 +1,4 @@
/* $OpenBSD: rusersd.c,v 1.24 2023/03/08 04:43:06 guenther Exp $ */
/* $OpenBSD: rusersd.c,v 1.25 2026/04/01 15:39:05 deraadt Exp $ */
/*-
* Copyright (c) 1993 John Brezak
@@ -80,15 +80,6 @@ main(int argc, char *argv[])
exit(1);
}
if (unveil("/dev", "r") == -1) {
syslog(LOG_ERR, "unveil /dev");
exit(1);
}
if (unveil(NULL, NULL) == -1) {
syslog(LOG_ERR, "unveil");
exit(1);
}
setgroups(1, &pw->pw_gid);
setresgid(pw->pw_gid, pw->pw_gid, pw->pw_gid);
setresuid(pw->pw_uid, pw->pw_uid, pw->pw_uid);
@@ -115,6 +106,15 @@ main(int argc, char *argv[])
(void) signal(SIGHUP, cleanup);
}
if (unveil("/dev", "r") == -1) {
syslog(LOG_ERR, "unveil /dev");
exit(1);
}
if (unveil(NULL, NULL) == -1) {
syslog(LOG_ERR, "unveil");
exit(1);
}
transp = svcudp_create(sock);
if (transp == NULL) {
syslog(LOG_ERR, "cannot create udp service.");