mirror of
https://github.com/Mercury-Language/mercury.git
synced 2026-04-22 12:53:47 +00:00
823de2d37b
The objective of this step is two-fold:
- to fix --inhibit-warnings, making it shut up all warning
and informational messages; and
- to ensure that it *stays* fixed, even when after new diagnostics
are added.
As part of this fix, this diff adds a whole bunch of new warning
options, in order to control the warnings that previously were
not controlled by any option. (There was no need for new
informational options.)
As it happens, we have long used severity_informational for messages
that did not report any information about the code being compiled,
but to report actions that the compiler was taking. Create a new
option category, oc_report, for the new options that now control
those diagnostics.
---------------------
compiler/error_spec.m:
Change severity_warning and severity_informational to take an option
as as argument. The semantics is that the diagnostic in which
the severity occurs is conditional on that option, meaning that
it is printed only if that option is set to "yes".
Delete the severity_conditional function symbol from the severity
type, since the mechanism just above handles its only use case.
Define subtypes to represent error_specs in a standard form.
compiler/error_sort.m:
Provide operations to convert error specs into their standard form.
Make the sorting operation itself operate on the standard form.
compiler/write_error_spec.m:
Convert error_specs to standard form before writing them out,
in order to avoid duplicating the code for their standardization.
Change the code that writes out error_specs to operate on the
standard form. Implement the test implicit in the warning and
and informational severities in this code.
compiler/error_util.m:
compiler/compiler_util.m:
Delete operations that do not make sense with the new severity type.
---------------------
compiler/options.m:
Add new options to control all the previously-uncontrolled
warning and informational messages.
NEWS.md:
Announce the *public* new options.
compiler/option_categories.m:
compiler/print_help.m:
Add the new option category, and fake-include it in the help text
and the user guide. (The inclusion is fake because none of the
options in the new category are user visible, meaning the section
containing them is not visible either.)
---------------------
compiler/det_infer_goal.m:
Start a severity warning diagnostic with "Warning:"
instead of "Error:".
compiler/mark_trace_goals.m:
Fix an incorrect error message.
compiler/purity.m:
Replace a correct/incorrect color pair with two inconsistent colors,
because there is a reasonable probability of each one being right.
---------------------
compiler/accumulator.m:
compiler/add_clause.m:
compiler/add_mode.m:
compiler/add_pragma.m:
compiler/add_pragma_tabling.m:
compiler/add_pred.m:
compiler/add_type.m:
compiler/check_module_interface.m:
compiler/check_type_inst_mode_defns.m:
compiler/check_typeclass.m:
compiler/color_schemes.m:
compiler/common.m:
compiler/convert_import_use.m:
compiler/convert_parse_tree.m:
compiler/dead_proc_elim.m:
compiler/det_check_proc.m:
compiler/det_check_switch.m:
compiler/det_infer_goal.m:
compiler/du_type_layout.m:
compiler/format_call_errors.m:
compiler/grab_modules.m:
compiler/hlds_call_tree.m:
compiler/inst_check.m:
compiler/introduce_parallelism.m:
compiler/make_hlds_error.m:
compiler/make_hlds_warn.m:
compiler/mark_tail_calls.m:
compiler/mark_trace_goals.m:
compiler/mercury_compile_main.m:
compiler/mercury_compile_make_hlds.m:
compiler/mode_errors.m:
compiler/modes.m:
compiler/module_qual.qual_errors.m:
compiler/opt_deps_spec.m:
compiler/options_file.m:
compiler/parse_goal.m:
compiler/post_term_analysis.m:
compiler/post_typecheck.m:
compiler/pre_typecheck.m:
compiler/purity.m:
compiler/read_modules.m:
compiler/recompilation.check.m:
compiler/simplify_goal.m:
compiler/simplify_goal_call.m:
compiler/simplify_goal_disj.m:
compiler/simplify_goal_ite.m:
compiler/split_parse_tree_src.m:
compiler/state_var.m:
compiler/stratify.m:
compiler/style_checks.m:
compiler/superhomogeneous.m:
compiler/table_gen.m:
compiler/term_constr_errors.m:
compiler/term_errors.m:
compiler/termination.m:
compiler/typecheck_clauses.m:
compiler/typecheck_error_overload.m:
compiler/typecheck_error_undef.m:
compiler/typecheck_errors.m:
compiler/typecheck_msgs.m:
compiler/unused_args.m:
compiler/unused_imports.m:
compiler/warn_unread_modules.m:
compiler/write_module_interface_files.m:
Conform to the changes above, mostly by either
- adding an option to all warning and informational messages,
sometimes using existing warning options and sometimes new ones,
or
- turning already explicitly-conditional-on-an-option messages
into implicitly-conditional-on-that-option messages.
---------------------
tests/invalid/one_member.m:
Conform to the change in det_infer_goal.m.
tests/invalid/require_tailrec_1.err_exp:
tests/invalid/require_tailrec_2.err_exp:
Actually obey the options for these modules in Mercury.options.
tests/invalid_purity/purity.err_exp:
tests/warnings/purity_warnings.err_exp:
Conform to the change in purity.m.
tests/warnings/moved_trace_goal.err_exp:
Conform to the change in mark_trace_goals.m.
tests/warnings/help_text.err_exp:
Expect the documentation of all the new options.
1.6 KiB
1.6 KiB
require_tailrec_2.m:049: In mode number 1 of predicate `map1'/3:
require_tailrec_2.m:049: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:056: In mode number 1 of predicate `map2'/3:
require_tailrec_2.m:056: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:089: In mode number 1 of predicate `qsortapp_1'/2:
require_tailrec_2.m:089: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:098: In mode number 1 of predicate `qsortapp_2'/2:
require_tailrec_2.m:098: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:107: In mode number 1 of predicate `qsortapp_3'/2:
require_tailrec_2.m:107: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:116: In mode number 1 of predicate `qsortapp_4'/2:
require_tailrec_2.m:116: error: self-recursive call is not tail recursive.
require_tailrec_2.m:125: In mode number 1 of predicate `qsortapp_5'/2:
require_tailrec_2.m:125: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:134: In mode number 1 of predicate `qsortapp_6'/2:
require_tailrec_2.m:134: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:141: In `:- pragma require_tail_recursion' for function
require_tailrec_2.m:141: `cons'/2:
require_tailrec_2.m:141: warning: the code defining this function contains no
require_tailrec_2.m:141: recursive calls at all, tail-recursive or otherwise.
require_tailrec_2.m:049: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:056: In mode number 1 of predicate `map2'/3:
require_tailrec_2.m:056: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:089: In mode number 1 of predicate `qsortapp_1'/2:
require_tailrec_2.m:089: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:098: In mode number 1 of predicate `qsortapp_2'/2:
require_tailrec_2.m:098: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:107: In mode number 1 of predicate `qsortapp_3'/2:
require_tailrec_2.m:107: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:116: In mode number 1 of predicate `qsortapp_4'/2:
require_tailrec_2.m:116: error: self-recursive call is not tail recursive.
require_tailrec_2.m:125: In mode number 1 of predicate `qsortapp_5'/2:
require_tailrec_2.m:125: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:134: In mode number 1 of predicate `qsortapp_6'/2:
require_tailrec_2.m:134: warning: self-recursive call is not tail recursive.
require_tailrec_2.m:141: In `:- pragma require_tail_recursion' for function
require_tailrec_2.m:141: `cons'/2:
require_tailrec_2.m:141: warning: the code defining this function contains no
require_tailrec_2.m:141: recursive calls at all, tail-recursive or otherwise.