From c9717eabc04762868fb65460ec510cad505af206 Mon Sep 17 00:00:00 2001 From: matthieu Date: Sat, 13 Dec 2014 08:57:15 +0000 Subject: [PATCH] fix arc4random_uniform() usage. Noticed by deraadt@ --- app/ico/ico.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/ico/ico.c b/app/ico/ico.c index 5eb26c91c..e3bdebed5 100644 --- a/app/ico/ico.c +++ b/app/ico/ico.c @@ -1013,8 +1013,8 @@ do_ico_window(void *ptr) icoX = ((closure->winW - icoW) * (rand() & 0xFF)) >> 8; icoY = ((closure->winH - icoH) * (rand() & 0xFF)) >> 8; #else - icoX = ((closure->winW - icoW) * arc4random_uniform(0xFF)) >> 8; - icoY = ((closure->winH - icoH) * arc4random_uniform(0xFF)) >> 8; + icoX = ((closure->winW - icoW) * arc4random_uniform(0x100)) >> 8; + icoY = ((closure->winH - icoH) * arc4random_uniform(0x100)) >> 8; #endif /* Bounce the box in the window */