From c1c10b3e4df2c66efcaf6ac79bc32531887d8791 Mon Sep 17 00:00:00 2001 From: jsg Date: Mon, 23 Feb 2026 00:38:34 +0000 Subject: [PATCH] don't return an error when skipping sysfs bits in amdgpu_ras_sysfs_create() should avoid fatal init error on Radeon VII reported by Justin Roberts --- sys/dev/pci/drm/amd/amdgpu/amdgpu_ras.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/pci/drm/amd/amdgpu/amdgpu_ras.c b/sys/dev/pci/drm/amd/amdgpu/amdgpu_ras.c index 58c069dee5c..f2f463cdf44 100644 --- a/sys/dev/pci/drm/amd/amdgpu/amdgpu_ras.c +++ b/sys/dev/pci/drm/amd/amdgpu/amdgpu_ras.c @@ -1807,14 +1807,12 @@ int amdgpu_ras_sysfs_create(struct amdgpu_device *adev, if (!obj || obj->attr_inuse) return -EINVAL; - STUB(); - return -ENOSYS; -#ifdef notyet get_obj(obj); snprintf(obj->fs_data.sysfs_name, sizeof(obj->fs_data.sysfs_name), "%s_err_count", head->name); +#ifdef notyet obj->sysfs_attr = (struct device_attribute){ .attr = { .name = obj->fs_data.sysfs_name, @@ -1830,11 +1828,11 @@ int amdgpu_ras_sysfs_create(struct amdgpu_device *adev, put_obj(obj); return -EINVAL; } +#endif obj->attr_inuse = 1; return 0; -#endif } int amdgpu_ras_sysfs_remove(struct amdgpu_device *adev,