From 9532dfe99015c9731e8bd3c76c781a67e6533b36 Mon Sep 17 00:00:00 2001 From: op Date: Wed, 1 Apr 2026 11:20:58 +0000 Subject: [PATCH] fix possible out of bound in text_to_netaddr diff from Renaud Allard (renaud at allard.it), thanks! ok deraadt --- usr.sbin/smtpd/to.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/smtpd/to.c b/usr.sbin/smtpd/to.c index be9ff01417c..148ca7f5ef5 100644 --- a/usr.sbin/smtpd/to.c +++ b/usr.sbin/smtpd/to.c @@ -1,4 +1,4 @@ -/* $OpenBSD: to.c,v 1.50 2023/05/31 16:51:46 op Exp $ */ +/* $OpenBSD: to.c,v 1.51 2026/04/01 11:20:58 op Exp $ */ /* * Copyright (c) 2009 Jacek Masiulaniec @@ -248,7 +248,7 @@ text_to_netaddr(struct netaddr *netaddr, const char *s) s += 5; if ((len = strlcpy(buf, s, sizeof buf)) >= sizeof buf) return 0; - if (buf[len-1] != ']') + if (len == 0 || buf[len-1] != ']') return 0; buf[len-1] = 0; }