From 3a5a2baaf57ecd6bb367bd9651db722f2c83fda7 Mon Sep 17 00:00:00 2001 From: tobhe Date: Fri, 3 Apr 2020 09:11:23 +0000 Subject: [PATCH] Port set in 'sin_port' should be htons() not ntohs(). Found by Wataru Ashihara ok patrick@ --- sbin/iked/iked.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sbin/iked/iked.c b/sbin/iked/iked.c index 85032d8eb3c..aa0bcd311b6 100644 --- a/sbin/iked/iked.c +++ b/sbin/iked/iked.c @@ -1,4 +1,4 @@ -/* $OpenBSD: iked.c,v 1.41 2020/01/16 20:05:00 tobhe Exp $ */ +/* $OpenBSD: iked.c,v 1.42 2020/04/03 09:11:23 tobhe Exp $ */ /* * Copyright (c) 2019 Tobias Heider @@ -228,17 +228,17 @@ parent_configure(struct iked *env) ss.ss_family = AF_INET; if ((env->sc_opts & IKED_OPT_NATT) == 0 && env->sc_nattport == IKED_NATT_PORT) - config_setsocket(env, &ss, ntohs(IKED_IKE_PORT), PROC_IKEV2); + config_setsocket(env, &ss, htons(IKED_IKE_PORT), PROC_IKEV2); if ((env->sc_opts & IKED_OPT_NONATT) == 0) - config_setsocket(env, &ss, ntohs(env->sc_nattport), PROC_IKEV2); + config_setsocket(env, &ss, htons(env->sc_nattport), PROC_IKEV2); bzero(&ss, sizeof(ss)); ss.ss_family = AF_INET6; if ((env->sc_opts & IKED_OPT_NATT) == 0 && env->sc_nattport == IKED_NATT_PORT) - config_setsocket(env, &ss, ntohs(IKED_IKE_PORT), PROC_IKEV2); + config_setsocket(env, &ss, htons(IKED_IKE_PORT), PROC_IKEV2); if ((env->sc_opts & IKED_OPT_NONATT) == 0) - config_setsocket(env, &ss, ntohs(env->sc_nattport), PROC_IKEV2); + config_setsocket(env, &ss, htons(env->sc_nattport), PROC_IKEV2); /* * pledge in the parent process: