Files
mercury/compiler/pd_term.m
Zoltan Somogyi f9fe8dcf61 Improve the error messages generated for determinism errors involving committed
Estimated hours taken: 8
Branches: main

Improve the error messages generated for determinism errors involving committed
choice contexts. Previously, we printed a message to the effect that e.g.
a cc pred is called in context that requires all solutions, but we didn't say
*why* the context requires all solutions. We now keep track of all the goals
to the right that could fail, since it is these goals that may reject the first
solution of a committed choice goal.

The motivation for this diff was the fact that I found that locating the
failing goal can be very difficult if the conjunction to the right is
a couple of hundred lines long. This would have been a nontrivial problem,
since (a) unifications involving values of user-defined types are committed
choice goals, and (b) we can expect uses of user-defined types to increase.

compiler/det_analysis.m:
	Keep track of goals to the right of the current goal that could fail,
	and include them in the error representation if required.

compiler/det_report.m:
	Include the list of failing goals to the right in the representations
	of determinism errors involving committed committed choice goals.

	Convert the last part of this module that wasn't using error_util
	to use error_util. Make most parts of this module just construct
	error message specifications; print those specifications (using
	error_util) in only a few places.

compiler/hlds_out.m:
	Add a function for use by the new code in det_report.m.

compiler/error_util.m:
	Add a function for use by the new code in det_report.m.

compiler/error_util.m:
compiler/compiler_util.m:
	Error_util is still changing reasonably often, and yet it is
	included in lots of modules, most of which need only a few simple
	non-parse-tree-related predicates from it (e.g. unexpected).
	Move those predicates to a new module, compiler_util.m. This also
	eliminates some undesirable dependencies from libs to parse_tree.

compiler/libs.m:
	Include compiler_util.m.

compiler/notes/compiler_design.html:
	Document compiler_util.m, and fix the documentation of some other
	modules.

compiler/*.m:
	Import compiler_util instead of or in addition to error_util.
	To make this easier, consistently use . instead of __ for module
	qualifying module names.

tests/invalid/det_errors_cc.{m,err_exp}:
	Add this new test case to test the error messages for cc contexts.

tests/invalid/det_errors_deet.{m,err_exp}:
	Add this new test case to test the error messages for unifications
	inside function symbols.

tests/invalid/Mmakefile:
	Add the new test cases.

tests/invalid/det_errors.err_exp:
tests/invalid/magicbox.err_exp:
	Change the expected output to conform to the change in det_report.m,
	which is now more consistent.
2005-10-28 02:11:03 +00:00

326 lines
12 KiB
Mathematica

%-----------------------------------------------------------------------------%
% vim: ft=mercury ts=4 sw=4 et
%-----------------------------------------------------------------------------%
% Copyright (C) 1998-2001, 2003-2005 The University of Melbourne.
% This file may only be copied under the terms of the GNU General
% Public License - see the file COPYING in the Mercury distribution.
%-----------------------------------------------------------------------------%
%
% File: pd_term.m
% Main author: stayl
%
% Termination checking for the deforestation process.
% There are two places where care must be taken to ensure
% termination of the process:
%
% - when unfolding a call to a recursive procedure
% - when creating a new version, to avoid creating an infinite sequence of
% new versions for which folding never occurs.
%
% For conjunctions, count up the length of the conjunction.
% For each pair of calls on the end of the conjunction,
% this length must decrease for the check to succeed.
%
% For single calls, the first call records the sizes of the insts
% of all the arguments. If the total size of a later call increases,
% the increasing arguments are removed from the record. If there are
% no decreasing arguments, the termination check fails. Otherwise
% the check succeeds and the new argument sizes are recorded.
%
% There are many possible improvements to this:
%
% - Partition on subterms of arguments rather than whole arguments - useful
% when partially instantiated structures are present.
% - Use homeomorphic embedding instead of term sizes as suggested in
% the papers on partial deduction from K.U. Leuven. This will be
% useful (necessary?) if we start propagating equality constraints.
%
%-----------------------------------------------------------------------------%
:- module transform_hlds__pd_term.
:- interface.
:- import_module hlds.hlds_goal.
:- import_module hlds.hlds_module.
:- import_module hlds.hlds_pred.
:- import_module hlds.instmap.
:- import_module transform_hlds.pd_info.
:- import_module list.
:- import_module std_util.
% pd_term__global_check(Module, CallGoal1, BetweenGoals, CallGoal2,
% InstMap, Versions, Info0, Info, Result):
%
% Check whether a new version can be created for the conjunction
% (CallGoal1, BetweenGoals, CallGoal2) without the deforestation
% process looping.
%
:- pred pd_term__global_check(module_info::in, hlds_goal::in,
list(hlds_goal)::in, maybe(hlds_goal)::in, instmap::in,
version_index::in, global_term_info::in,
global_term_info::out, global_check_result::out) is det.
% A proc_pair holds the pred_proc_ids of the procedures called at
% the ends of a conjunction to be deforested.
% The maybe(pred_proc_id) is `no' in the case of a predicate
% created for constraint propagation.
:- type proc_pair == pair(pred_proc_id, maybe(pred_proc_id)).
:- type global_check_result
---> ok(proc_pair, int)
; possible_loop(proc_pair, int, pred_proc_id)
; loop.
% Check whether a call can be unfolded without the
% unfolding process looping.
%
:- pred pd_term__local_check(module_info::in, hlds_goal::in, instmap::in,
local_term_info::in, local_term_info::out) is semidet.
:- pred pd_term__global_term_info_init(global_term_info::out) is det.
:- pred pd_term__local_term_info_init(local_term_info::out) is det.
:- pred pd_term__get_proc_term_info(local_term_info::in, pred_proc_id::in,
pd_proc_term_info::out) is semidet.
% Update the global termination information when we find out the
% pred_proc_id that has been assigned to a version.
%
:- pred pd_term__update_global_term_info(proc_pair::in, pred_proc_id::in,
int::in, global_term_info::in,global_term_info::out) is det.
:- type global_term_info.
:- type local_term_info.
:- type pd_proc_term_info.
%-----------------------------------------------------------------------------%
:- implementation.
:- import_module check_hlds.mode_util.
:- import_module hlds.hlds_pred.
:- import_module parse_tree.prog_data.
:- import_module transform_hlds.pd_util.
:- import_module assoc_list.
:- import_module bool.
:- import_module int.
:- import_module map.
:- import_module require.
:- import_module set.
:- type global_term_info
---> global_term_info(
single_covering_goals,
multiple_covering_goals
).
% We only deal with single atoms while unfolding.
:- type local_term_info == single_covering_goals.
% For single goals, use the argument partition method.
:- type single_covering_goals == map(pred_proc_id, pd_proc_term_info).
% Map from a pair of procedures at the end of the conjunction
% to be deforested and the most recent ancestor with this pair
% of goals.
:- type multiple_covering_goals ==
map(proc_pair, pair(int, maybe(pred_proc_id))).
% Mapping from argument to size.
:- type pd_proc_term_info == assoc_list(int, int).
%-----------------------------------------------------------------------------%
pd_term__global_term_info_init(TermInfo) :-
map__init(SingleGoals),
map__init(MultipleGoals),
TermInfo = global_term_info(SingleGoals, MultipleGoals).
pd_term__local_term_info_init(TermInfo) :-
map__init(TermInfo).
pd_term__get_proc_term_info(TermInfo, PredProcId, ProcTermInfo) :-
map__search(TermInfo, PredProcId, ProcTermInfo).
%-----------------------------------------------------------------------------%
pd_term__global_check(_ModuleInfo, EarlierGoal, BetweenGoals, MaybeLaterGoal,
_InstMap, Versions, !Info, Result) :-
!.Info = global_term_info(SingleGoalCover0, MultipleGoalCover0),
(
EarlierGoal = call(PredId1, ProcId1, _, _, _, _) - _,
Hd = (pred(List::in, Head::out) is semidet :-
List = [Head | _]
),
expand_calls(Hd, Versions, proc(PredId1, ProcId1), FirstPredProcId),
(
MaybeLaterGoal = yes(call(PredId2, ProcId2, _, _, _, _) - _),
expand_calls(list__last, Versions, proc(PredId2, ProcId2),
LastPredProcId),
MaybeLastPredProcId = yes(LastPredProcId)
;
MaybeLaterGoal = no,
MaybeLastPredProcId = no
)
->
ProcPair = FirstPredProcId - MaybeLastPredProcId,
list__length(BetweenGoals, Length),
(
map__search(MultipleGoalCover0, ProcPair,
MaxLength - MaybeCoveringPredProcId)
->
(
Length < MaxLength
->
Result = ok(ProcPair, Length),
% Set the maybe(pred_proc_id) when we create the new predicate.
map__set(MultipleGoalCover0, ProcPair,
Length - no, MultipleGoalCover)
;
Length = MaxLength,
MaybeCoveringPredProcId = yes(CoveringPredProcId)
->
% If the goals match, check that the argument insts decrease.
%If not, we may need to do a generalisation step.
Result = possible_loop(ProcPair, Length, CoveringPredProcId),
MultipleGoalCover = MultipleGoalCover0
;
Result = loop,
MultipleGoalCover = MultipleGoalCover0
)
;
% We haven't seen this pair before, so it must be okay
% to specialise.
Result = ok(ProcPair, Length),
% Set the maybe(pred_proc_id) when we create the new predicate.
map__set(MultipleGoalCover0, ProcPair, Length - no,
MultipleGoalCover)
),
SingleGoalCover = SingleGoalCover0
;
error("pd_term__global_check")
),
!:Info = global_term_info(SingleGoalCover, MultipleGoalCover).
% We don't want to use folded calls to parent versions
% when doing the global termination check, since that
% could give a sequence:
% old ....pred1
% new1 .... pred1
% new2 ....... pred1
% new3 ......... pred1
% Instead, we expand to predicates from the original program,
% which must contain a finite number of pairs of pred_proc_ids.
%
:- pred expand_calls(pred(list(pred_proc_id), pred_proc_id)::
in(pred(in, out) is semidet), version_index::in,
pred_proc_id::in, pred_proc_id::out) is semidet.
expand_calls(GetEnd, Versions, PredProcId0, PredProcId) :-
( map__search(Versions, PredProcId0, VersionInfo) ->
Calls = VersionInfo ^ version_deforest_calls,
call(GetEnd, Calls, PredProcId1),
expand_calls(GetEnd, Versions, PredProcId1, PredProcId)
;
PredProcId = PredProcId0
).
%-----------------------------------------------------------------------------%
pd_term__local_check(ModuleInfo, Goal1, InstMap, !Cover) :-
Goal1 = call(PredId, ProcId, Args, _, _, _) - _,
( map__search(!.Cover, proc(PredId, ProcId), CoveringInstSizes0) ->
pd_term__do_local_check(ModuleInfo, InstMap, Args,
CoveringInstSizes0, CoveringInstSizes),
map__set(!.Cover, proc(PredId, ProcId), CoveringInstSizes, !:Cover)
;
pd_term__initial_sizes(ModuleInfo, InstMap,
Args, 1, ArgInstSizes),
map__set(!.Cover, proc(PredId, ProcId), ArgInstSizes, !:Cover)
).
:- pred pd_term__do_local_check(module_info::in, instmap::in,
list(prog_var)::in, assoc_list(int, int)::in,
assoc_list(int, int)::out) is semidet.
pd_term__do_local_check(ModuleInfo, InstMap, Args, OldSizes, NewSizes) :-
pd_term__get_matching_sizes(ModuleInfo, InstMap, Args,
OldSizes, NewSizes1, OldTotal, NewTotal),
( NewTotal < OldTotal ->
NewSizes = NewSizes1
;
pd_term__split_out_non_increasing(OldSizes, NewSizes1, yes, NewSizes)
).
%-----------------------------------------------------------------------------%
pd_term__update_global_term_info(ProcPair, PredProcId, Size, !TermInfo) :-
!.TermInfo = global_term_info(Single, Multiple0),
map__set(Multiple0, ProcPair, Size - yes(PredProcId), Multiple),
!:TermInfo = global_term_info(Single, Multiple).
%-----------------------------------------------------------------------------%
:- pred pd_term__initial_sizes(module_info::in, instmap::in,
list(prog_var)::in, int::in, assoc_list(int, int)::out) is det.
pd_term__initial_sizes(_, _, [], _, []).
pd_term__initial_sizes(ModuleInfo, InstMap, [Arg | Args], ArgNo,
[ArgNo - Size | Sizes]) :-
NextArgNo = ArgNo + 1,
pd_term__initial_sizes(ModuleInfo, InstMap, Args, NextArgNo, Sizes),
instmap__lookup_var(InstMap, Arg, ArgInst),
pd_util__inst_size(ModuleInfo, ArgInst, Size).
%-----------------------------------------------------------------------------%
:- pred pd_term__get_matching_sizes(module_info::in, instmap::in,
list(prog_var)::in, assoc_list(int, int)::in,
assoc_list(int, int)::out, int::out, int::out) is det.
pd_term__get_matching_sizes(_, _, _, [], [], 0, 0).
pd_term__get_matching_sizes(ModuleInfo, InstMap, Args,
[ArgNo - OldSize | OldSizes], [ArgNo - NewSize | NewSizes],
OldTotal, NewTotal) :-
pd_term__get_matching_sizes(ModuleInfo, InstMap, Args,
OldSizes, NewSizes, OldTotal1, NewTotal1),
list__index1_det(Args, ArgNo, Arg),
instmap__lookup_var(InstMap, Arg, ArgInst),
pd_util__inst_size(ModuleInfo, ArgInst, NewSize),
OldTotal = OldTotal1 + OldSize,
NewTotal = NewTotal1 + NewSize.
%-----------------------------------------------------------------------------%
:- pred pd_term__split_out_non_increasing(assoc_list(int, int)::in,
assoc_list(int, int)::in, bool::out, assoc_list(int, int)::out) is semidet.
pd_term__split_out_non_increasing([], [], no, []).
pd_term__split_out_non_increasing([_|_], [], _, _) :-
error("pd_term__split_out_non_increasing").
pd_term__split_out_non_increasing([], [_|_], _, _) :-
error("pd_term__split_out_non_increasing").
pd_term__split_out_non_increasing([Arg - OldSize | Args0],
[_ - NewSize | Args], FoundDecreasing, NonIncreasing) :-
pd_term__split_out_non_increasing(Args0, Args,
FoundDecreasing1, NonIncreasing1),
( NewSize =< OldSize ->
NonIncreasing = [Arg - NewSize | NonIncreasing1],
( NewSize = OldSize ->
FoundDecreasing = no
;
FoundDecreasing = yes
)
;
NonIncreasing = NonIncreasing1,
FoundDecreasing = FoundDecreasing1
).
%-----------------------------------------------------------------------------%
%-----------------------------------------------------------------------------%