Files
mercury/compiler/simplify_proc.m
Zoltan Somogyi 783f4b2be4 Fix singleton warnings for code with 'some [...]' goals.
The code in make_hlds_warn.m that is intended to generate singleton warnings
hasn't ever been able to handle code containing 'some [...]' goals properly.
The reason is that

- add_clause.m invokes make_hlds_warn.m only *after* it does quantification
  on the body of the clause being added to the HLDS, but

- quantification has always replaced all lists of quantified variables
  with the empty list.

This meant that

- we never could report code in which the only occurrence of a variable
  was in a list of quantified variables, which is something we *should*
  warn about, and

- we always did generate a singleton warning for code such as
  "some [Val] map.search(Map, Key, Val)", which is something we *should not*
  warn about.

This diff fixes this problem.

The main change is a mechanism that allows us to tell quantification.m
to keep lists of quantified variables intact. However, since the rest
of the compiler does not react well to these lists not being empty,
this diff

- gets make_hlds_warn.m to report whether the clause body goal, in which
  quantification.m was told to preserve any lists of quantified variables,
  *actually contained* any nonempty lists of quantified variables, and

- if it did, then we invoke quantification.m again, this time telling it
  to nuke all lists of quantified variables.

This nuking has to be done relatively rarely, because only a very small
fraction of clauses contain any explicit quantification.

(An alternative design would be for make_hlds_warn.m to always nuke
any nonempty list of quantified variables it traversed. However, this would
require *always* rebuilding the clause body goal, which would probably
be slower on average.)

The above is the main change in this diff. However, the change that is
responsible for the bulk of the diff is the addition of a flag to
exist_quant scopes to specify whether that scope was created by the user
or by the compiler. This is needed because if make_hlds_warn.m sees code
such as "some [Val] map.search(Map, Key, Val)", it definitely *should*
generate a warning about Val being singleton (if it does not occur outside
this code) if the "some [Val]" scope was put there by the compiler.

compiler/make_hlds_warn.m:
    Treat user-generated exist_quant scopes as before (the old code did
    the right thing to generate warnings, it was just given wrong inputs).
    Treat compiler-generated exist_quant scopes as if they weren't there,
    for warning-generating purposes.

    To make this distinction possible, use separate code to handle
    exist_quant and promise_solutions scopes.

    Record whether the goal traversal has seen any nonempty lists of quantified
    variables, and return this info to the caller in add_clause.m.

    Encode the nonempty nature of a list in the argument structure of a
    predicate.

    Update some obsolete terminology in variable and field names.

    Clarify the logic of some code.

compiler/quantification.m:
    Add the keep_quant/do_not_keep_quant switch described above.

    Add some documentation of the predicates to which it is applicable.

    Add free_goal_expr_vars, a version of free_goal_vars that takes
    only a goal expr, without the goal info. At one point, I thought
    this diff needed it. It does not, so the new function is not used,
    but there is also not much point in deleting it, Simplify the code
    of free_goal_vars, deleting one of its callees after inlining it
    at its only call site.

    Replace a appended-to-at-the-front-and-then-reversed list with a cord.

compiler/hlds_goal.m:
    Add the created-by-user-or-compiler flag to exist_quant scopes.

compiler/add_clause.m:
    Move the code that invokes make_hlds_warn.m to warn about singletons
    into the clauses_info_add_clause predicate, whose subcontractor
    add_clause_transform does the initial quantification. The reason
    for this move is that we have never generated singleton variable warnings
    for clauses that were read in from .opt files, or for clauses which are
    known to have syntax errors. With the new setup, if we such clauses,
    clauses_info_add_clause can, and does, tell add_clause_transform
    to tell quantification.m to nuke lists of quantified variable
    right away. It is only for the clauses we *can* warn about
    that clauses_info_add_clause will tell add_clause_transform
    to keep those variables, and will then itself invoke the code
    in make_hlds_warn.m that warns about singletons, followed, if needed,
    by a var-list-nuking reinvocation of quantification.

    This centralization of the code relevant to warning code in
    clauses_info_add_clause also allows the deletion of several of its
    output arguments, since its two callers used those arguments
    only to invoke the warning-generation code. It also eliminates
    the duplication of code in those two callers.

compiler/instance_method_clauses.m:
    Conform to the change in add_clause.m.

compiler/add_foreign_proc.m:
compiler/assertion.m:
compiler/constraint.m:
compiler/cse_detection.m:
compiler/det_analysis.m:
compiler/det_report.m:
compiler/format_call.m:
compiler/goal_expr_to_goal.m:
compiler/goal_util.m:
compiler/hlds_desc.m:
compiler/hlds_out_goal.m:
compiler/interval.m:
compiler/lambda.m:
compiler/mark_tail_calls.m:
compiler/ml_code_gen.m:
compiler/mode_constraints.m:
compiler/modecheck_goal.m:
compiler/polymorphism_goal.m:
compiler/pre_quantification.m:
compiler/purity.m:
compiler/saved_vars.m:
compiler/simplify_goal_scope.m:
compiler/simplify_proc.m:
compiler/state_var.m:
compiler/stm_expand.m:
compiler/superhomogeneous.m:
compiler/switch_detection.m:
compiler/try_expand.m:
compiler/typecheck.m:
compiler/unique_modes.m:
    Conform to the change in hlds_goal.m and/or quantification.m.

compiler/options.m:
    Add a way to detect the presence of this fix in the installed compiler.

tests/valid/Mmakefile:
    Enable the old test case for this problem, some_singleton,
    which we haven't passed until now.

tests/warnings/Mmakefile:
    Enable the missing_singleton_warning test case, which we haven't passed
    until now.
2023-06-10 09:59:00 +02:00

868 lines
36 KiB
Mathematica

%-----------------------------------------------------------------------------%
% vim: ft=mercury ts=4 sw=4 et
%-----------------------------------------------------------------------------%
% Copyright (C) 2014 The Mercury team.
% This file may only be copied under the terms of the GNU General
% Public License - see the file COPYING in the Mercury distribution.
%-----------------------------------------------------------------------------%
%
% File: simplify_proc.m.
%
% This module handles top level invocations of simplification.
%
% Most such invocations simplify the body of a procedure, or the bodies
% of all the procedures in a predicate. However, in some cases some other
% compiler passes (such as deforestation or partial evaluation) want to
% simplify a goal that is not the body of a procedure.
%
%-----------------------------------------------------------------------------%
:- module check_hlds.simplify.simplify_proc.
:- interface.
:- import_module check_hlds.simplify.simplify_tasks.
:- import_module hlds.
:- import_module hlds.hlds_goal.
:- import_module hlds.hlds_module.
:- import_module hlds.hlds_pred.
:- import_module hlds.instmap.
:- import_module parse_tree.
:- import_module parse_tree.error_util.
:- import_module io.
:- import_module list.
:- import_module maybe.
%-----------------------------------------------------------------------------%
% Simplify all the given procedures of the given predicate.
% Add any resulting messages to the error spec accumulator.
%
% Used by mercury_compiler_front_end.m when doing compilation pass-by-pass.
%
:- pred simplify_pred_procs(maybe(io.text_output_stream)::in,
simplify_tasks::in, pred_id::in, list(proc_id)::in,
module_info::in, module_info::out, pred_info::in, pred_info::out,
error_spec_accumulator::in, error_spec_accumulator::out) is det.
% Simplify the given procedure. Throw away any resulting error messages.
%
% Used by compiler passes after the front end that need (or maybe just
% want) to eliminate unnecessary parts of the procedure.
%
:- pred simplify_proc(maybe(io.text_output_stream)::in, simplify_tasks::in,
pred_id::in, proc_id::in, module_info::in, module_info::out,
proc_info::in, proc_info::out) is det.
% simplify_goal_update_vars_in_proc(SimplifyTasks, !ModuleInfo,
% PredId, ProcId, !ProcInfo, InstMap0, !Goal, CostDelta):
%
% Perform the specified simplification tasks on !Goal, which should be
% part of the procedure identified by PredId and ProcId. InstMap0
% should be the instmap immediately before !.Goal.
%
% We may update !ModuleInfo during the course of updating instmaps
% to reflect any changes made to the code. If the modifications to !Goal
% add any new variables, add these to !ProcInfo.
%
% !.Goal does NOT need to be the entire body of the procedure it appears
% in; it can be just a part of it. This is why we return the updated goal
% in !:Goal, not in !:ProcInfo.
%
% Used by partial evaluation.
%
:- pred simplify_goal_update_vars_in_proc(simplify_tasks::in,
module_info::in, module_info::out, pred_id::in, proc_id::in,
proc_info::in, proc_info::out, instmap::in, hlds_goal::in, hlds_goal::out,
int::out) is det.
%-----------------------------------------------------------------------------%
%-----------------------------------------------------------------------------%
:- implementation.
:- import_module check_hlds.det_analysis.
:- import_module check_hlds.det_util.
:- import_module check_hlds.recompute_instmap_deltas.
:- import_module check_hlds.simplify.common.
:- import_module check_hlds.simplify.format_call.
:- import_module check_hlds.simplify.simplify_goal.
:- import_module check_hlds.simplify.simplify_info.
:- import_module hlds.code_model.
:- import_module hlds.passes_aux.
:- import_module hlds.quantification.
:- import_module hlds.status.
:- import_module libs.
:- import_module libs.globals.
:- import_module libs.optimization_options.
:- import_module libs.options.
:- import_module mdbcomp.
:- import_module mdbcomp.sym_name.
:- import_module parse_tree.error_spec.
:- import_module parse_tree.prog_data.
:- import_module parse_tree.prog_data_foreign.
:- import_module parse_tree.var_table.
:- import_module transform_hlds.
:- import_module transform_hlds.direct_arg_in_out.
:- import_module bool.
:- import_module int.
:- import_module map.
:- import_module require.
:- import_module set.
:- import_module string.
:- import_module varset.
%-----------------------------------------------------------------------------%
simplify_pred_procs(_, _, _, [], !ModuleInfo, !PredInfo, !Specs).
simplify_pred_procs(MaybeProgressStream, SimplifyTasks, PredId,
[ProcId | ProcIds], !ModuleInfo, !PredInfo, !Specs) :-
simplify_pred_proc(MaybeProgressStream, SimplifyTasks, PredId, ProcId,
!ModuleInfo, !PredInfo, !Specs),
simplify_pred_procs(MaybeProgressStream, SimplifyTasks, PredId, ProcIds,
!ModuleInfo, !PredInfo, !Specs).
:- pred simplify_pred_proc(maybe(io.text_output_stream)::in,
simplify_tasks::in, pred_id::in, proc_id::in,
module_info::in, module_info::out, pred_info::in, pred_info::out,
error_spec_accumulator::in, error_spec_accumulator::out) is det.
simplify_pred_proc(_MaybeProgressStream, SimplifyTasks, PredId, ProcId,
!ModuleInfo, !PredInfo, !Specs) :-
% XXX It is strange that simplify_proc prints progress messages,
% but simplify_pred_proc does not.
pred_info_get_proc_table(!.PredInfo, ProcTable0),
map.lookup(ProcTable0, ProcId, ProcInfo0),
simplify_proc_return_msgs(SimplifyTasks, PredId, ProcId,
!ModuleInfo, ProcInfo0, ProcInfo, ProcSpecs),
% This is ugly, but we want to avoid running the dependent parallel
% conjunction pass on predicates and even modules that do not contain
% parallel conjunctions (nearly all of them). Since simplification
% is always done, we use it to mark modules and procedures containing
% parallel conjunctions.
proc_info_get_has_parallel_conj(ProcInfo, HasParallelConj),
(
HasParallelConj = has_parallel_conj,
module_info_set_has_parallel_conj(!ModuleInfo)
;
HasParallelConj = has_no_parallel_conj
),
proc_info_get_has_user_event(ProcInfo, HasUserEvent),
(
HasUserEvent = has_user_event,
module_info_set_has_user_event(!ModuleInfo)
;
HasUserEvent = has_no_user_event
),
map.det_update(ProcId, ProcInfo, ProcTable0, ProcTable),
pred_info_set_proc_table(ProcTable, !PredInfo),
accumulate_error_specs_for_proc(ProcSpecs, !Specs).
simplify_proc(MaybeProgressStream, SimplifyTasks, PredId, ProcId,
!ModuleInfo, !ProcInfo) :-
trace [io(!IO)] (
(
MaybeProgressStream = no
;
MaybeProgressStream = yes(ProgressStream),
maybe_write_pred_progress_message(ProgressStream, !.ModuleInfo,
"Simplifying", PredId, !IO)
)
),
simplify_proc_return_msgs(SimplifyTasks, PredId, ProcId, !ModuleInfo,
!ProcInfo, _).
simplify_goal_update_vars_in_proc(SimplifyTasks, !ModuleInfo,
PredId, ProcId, !ProcInfo, InstMap0, !Goal, CostDelta) :-
simplify_info_init(!.ModuleInfo, PredId, ProcId, !.ProcInfo,
SimplifyTasks, SimplifyInfo0),
% The nested context we construct is probably a lie; we don't actually
% know whether we are inside a goal duplicated for a switch, or a lambda,
% or a model_non procedure. However, this should be ok. The nested context
% is used for deciding what warnings and errors to generate, and
% we are not interested in those.
InsideDuplForSwitch = no,
NumEnclosingBarriers = 0u,
ProcIsModelNon = no,
NestedContext0 = simplify_nested_context(InsideDuplForSwitch,
ProcIsModelNon, NumEnclosingBarriers),
simplify_top_level_goal(!Goal, NestedContext0, InstMap0,
SimplifyInfo0, SimplifyInfo),
simplify_info_get_module_info(SimplifyInfo, !:ModuleInfo),
simplify_info_get_var_table(SimplifyInfo, VarTable),
simplify_info_get_rtti_varmaps(SimplifyInfo, RttiVarMaps),
proc_info_set_var_table(VarTable, !ProcInfo),
proc_info_set_rtti_varmaps(RttiVarMaps, !ProcInfo),
simplify_info_get_cost_delta(SimplifyInfo, CostDelta).
%-----------------------------------------------------------------------------%
% Simplify the given procedure. Return the resulting error messages.
%
:- pred simplify_proc_return_msgs(simplify_tasks::in, pred_id::in,
proc_id::in, module_info::in, module_info::out,
proc_info::in, proc_info::out, list(error_spec)::out) is det.
simplify_proc_return_msgs(SimplifyTasks0, PredId, ProcId, !ModuleInfo,
!ProcInfo, !:Specs) :-
simplify_proc_maybe_vary_parameters(!.ModuleInfo, PredId, !.ProcInfo,
SimplifyTasks0, SimplifyTasks),
module_info_pred_info(!.ModuleInfo, PredId, PredInfo0),
pred_info_get_markers(PredInfo0, Markers0),
( if check_marker(Markers0, marker_mode_check_clauses) then
simplify_proc_maybe_mark_modecheck_clauses(!ProcInfo)
else
true
),
% We must invoke analyze_and_optimize_format_calls before
% simplify_top_level_goal, for two reasons.
%
% First, excess assignment optimization may delete some of the
% unifications that build the format strings or values,
% which means that the goal it generates may not contain the
% information that analyze_and_optimize_format_calls needs to avoid
% spurious messages about unknown format strings or values.
%
% Second, analyze_and_optimize_format_calls generates nested
% conjunctions, which simplify_top_level_goal can eliminate.
%
% We therefore get determinism analysis to mark the procedure
% if its body contains any calls relevant to format_calls.m.
( if
check_marker(Markers0, marker_has_format_call),
SimplifyTasks ^ do_invoke_format_call = invoke_format_call
then
(
SimplifyTasks ^ do_warn_implicit_streams =
do_not_warn_implicit_streams,
ImplicitStreamWarnings = do_not_generate_implicit_stream_warnings
;
SimplifyTasks ^ do_warn_implicit_streams = warn_implicit_streams,
ImplicitStreamWarnings = generate_implicit_stream_warnings
),
simplify_proc_analyze_and_format_calls(!ModuleInfo, PredId, PredInfo0,
ProcId, !ProcInfo, ImplicitStreamWarnings, FormatSpecs)
else
% Either there are no format calls to check, or we don't want to
% optimize them and would ignore the added messages anyway.
FormatSpecs = []
),
simplify_info_init(!.ModuleInfo, PredId, ProcId, !.ProcInfo,
SimplifyTasks, Info0),
InsideDuplForSwitch = no,
NumEnclosingBarriers = 0u,
CodeModel = proc_info_interface_code_model(!.ProcInfo),
(
( CodeModel = model_det
; CodeModel = model_semi
),
ProcIsModelNon = no
;
CodeModel = model_non,
ProcIsModelNon = yes(imp_whole_proc)
),
NestedContext0 = simplify_nested_context(InsideDuplForSwitch,
ProcIsModelNon, NumEnclosingBarriers),
proc_info_get_initial_instmap(!.ModuleInfo, !.ProcInfo, InstMap0),
proc_info_get_goal(!.ProcInfo, Goal0),
simplify_top_level_goal(Goal0, Goal, NestedContext0, InstMap0,
Info0, Info),
proc_info_set_goal(Goal, !ProcInfo),
simplify_info_get_var_table(Info, VarTable0),
simplify_info_get_rtti_varmaps(Info, RttiVarMaps),
simplify_info_get_elim_vars(Info, ElimVarsLists0),
% We sort the lists basically on the number of the first variable.
list.sort(ElimVarsLists0, ElimVarsLists),
list.condense(ElimVarsLists, ElimVars),
delete_var_entries(ElimVars, VarTable0, VarTable1),
simplify_info_get_module_info(Info, !:ModuleInfo),
% We only eliminate vars that cannot occur in RttiVarMaps.
( if simplify_do_after_front_end(Info) then
proc_info_get_var_name_remap(!.ProcInfo, VarNameRemap),
RenameVar =
( pred(V::in, N::in, VT0::in, VT::out) is det :-
lookup_var_entry(VT0, V, E0),
E = E0 ^ vte_name := N,
update_var_entry(V, E, VT0, VT)
),
map.foldl(RenameVar, VarNameRemap, VarTable1, VarTable),
proc_info_set_var_name_remap(map.init, !ProcInfo),
proc_info_get_headvars(!.ProcInfo, HeadVars),
proc_info_get_argmodes(!.ProcInfo, ArgModes),
find_and_record_any_direct_arg_in_out_posns(PredId, ProcId, VarTable,
HeadVars, ArgModes, !ModuleInfo)
else
VarTable = VarTable1
),
proc_info_set_var_table(VarTable, !ProcInfo),
proc_info_set_rtti_varmaps(RttiVarMaps, !ProcInfo),
simplify_info_get_has_parallel_conj(Info, HasParallelConj),
proc_info_set_has_parallel_conj(HasParallelConj, !ProcInfo),
simplify_info_get_has_user_event(Info, HasUserEvent),
proc_info_set_has_user_event(HasUserEvent, !ProcInfo),
simplify_info_get_deleted_call_callees(Info, CurDeletedCallCallees),
proc_info_get_deleted_call_callees(!.ProcInfo, DeletedCallCallees0),
set.union(CurDeletedCallCallees, DeletedCallCallees0, DeletedCallCallees),
proc_info_set_deleted_call_callees(DeletedCallCallees, !ProcInfo),
simplify_info_get_error_specs(Info, !:Specs),
!:Specs = FormatSpecs ++ !.Specs,
simplify_proc_maybe_warn_attribute_conflict(!.ModuleInfo, PredId,
!.ProcInfo, !Specs),
pred_info_get_status(PredInfo0, Status),
IsDefinedHere = pred_status_defined_in_this_module(Status),
(
IsDefinedHere = no,
% Don't generate any warnings or even errors if the predicate isn't
% defined here; any such messages will be generated when we compile
% the module the predicate comes from.
!:Specs = []
;
IsDefinedHere = yes
).
:- pred simplify_proc_maybe_vary_parameters(module_info::in, pred_id::in,
proc_info::in, simplify_tasks::in, simplify_tasks::out) is det.
simplify_proc_maybe_vary_parameters(ModuleInfo, PredId, ProcInfo,
!SimplifyTasks) :-
module_info_get_globals(ModuleInfo, Globals),
globals.lookup_string_option(Globals, common_struct_preds,
CommonStructPreds),
( if CommonStructPreds = "" then
TurnOffCommonStructByRequest = no
else
CommonStructPredIdStrs = string.split_at_char(',', CommonStructPreds),
( if
list.map(string.to_int, CommonStructPredIdStrs,
CommonStructPredIdInts)
then
PredIdInt = pred_id_to_int(PredId),
( if list.member(PredIdInt, CommonStructPredIdInts) then
TurnOffCommonStructByRequest = no
else
TurnOffCommonStructByRequest = yes
)
else
TurnOffCommonStructByRequest = no
)
),
proc_info_get_var_table(ProcInfo, VarTable0),
var_table_count(VarTable0, NumVars),
( if
( TurnOffCommonStructByRequest = yes
; NumVars > turn_off_common_struct_threshold
)
then
!SimplifyTasks ^ do_opt_common_structs := do_not_opt_common_structs
else
true
).
% If we have too many variables, common_struct used to take so long that
% either the compiler runs out of memory, or the user runs out of patience.
% In such cases, the fact that we would generate better code if the
% compilation finished is therefore of limited interest.
%
% However, since this limit was first imposed, we have optimized
% the compiler's infrastructure for such things, e.g. by using much more
% compact representations for sets of variables, which permit much faster
% operations on them. These changes do not eliminate the danger described
% above completely, but they do raise the threshold at which they can
% appear.
%
% As of 2020 october 11, the code of convert_options_to_globals in
% handle_options.m has just shy of 9,000 variables at the time of the
% first simplify pass (HLDS dump stage 65). The compiler can handle that
% easily, so the setting below allows for some growth.
%
:- func turn_off_common_struct_threshold = int.
turn_off_common_struct_threshold = 12000.
:- pred simplify_proc_maybe_mark_modecheck_clauses(
proc_info::in, proc_info::out) is det.
simplify_proc_maybe_mark_modecheck_clauses(!ProcInfo) :-
proc_info_get_goal(!.ProcInfo, Goal0),
Goal0 = hlds_goal(GoalExpr0, GoalInfo0),
( if
( GoalExpr0 = disj(_)
; GoalExpr0 = switch(_, _, _)
)
then
goal_info_add_feature(feature_mode_check_clauses_goal,
GoalInfo0, GoalInfo),
Goal = hlds_goal(GoalExpr0, GoalInfo),
proc_info_set_goal(Goal, !ProcInfo)
else
true
).
%-----------------------------------------------------------------------------%
:- pred simplify_proc_analyze_and_format_calls(
module_info::in, module_info::out, pred_id::in, pred_info::in,
proc_id::in, proc_info::in, proc_info::out,
maybe_generate_implicit_stream_warnings::in, list(error_spec)::out) is det.
simplify_proc_analyze_and_format_calls(!ModuleInfo, PredId, PredInfo0,
ProcId, !ProcInfo, ImplicitStreamWarnings, FormatSpecs) :-
proc_info_get_goal(!.ProcInfo, Goal0),
proc_info_get_var_table(!.ProcInfo, VarTable0),
analyze_and_optimize_format_calls(!.ModuleInfo, PredInfo0, !.ProcInfo,
ImplicitStreamWarnings, Goal0, MaybeGoal, FormatSpecs,
VarTable0, VarTable),
(
MaybeGoal = yes(Goal),
proc_info_set_goal(Goal, !ProcInfo),
proc_info_set_var_table(VarTable, !ProcInfo),
% The goals we replace format calls with are created with the
% correct nonlocals, but analyze_and_optimize_format_calls can
% take code for building a list of string.poly_types out of one
% scope (e.g. the condition of an if-then-else) and replace it
% with code to build the string directly in another scope
% (such as the then part of that if-then-else, if that is where
% the format call is). This can leave variables missing from
% the nonlocal fields of the original scopes. And since
% instmap_deltas are restricted to the goal's nonlocals,
% they need to be recomputed as well.
requantify_proc_general(ord_nl_maybe_lambda, !ProcInfo),
recompute_instmap_delta_proc(no_recomp_atomics,
!ProcInfo, !ModuleInfo),
% Put the new proc_info back into !ModuleInfo, since some of the
% following code could otherwise find obsolete information in there.
pred_info_set_proc_info(ProcId, !.ProcInfo, PredInfo0, PredInfo1),
% Remove the has_format_call marker from the pred_info before
% putting it back, since any optimizable format calls will already
% have been optimized. Since currently there is no program
% transformation that inserts calls to these predicates,
% there is no point in trying to optimize format_calls again later.
pred_info_get_markers(PredInfo1, Markers1),
remove_marker(marker_has_format_call, Markers1, Markers),
pred_info_set_markers(Markers, PredInfo1, PredInfo),
module_info_set_pred_info(PredId, PredInfo, !ModuleInfo)
;
MaybeGoal = no
% There should not be any updates to the var_table,
% but even if there are, throw them away, since they apply to a version
% of the goal that we will not be using.
).
%-----------------------------------------------------------------------------%
:- pred simplify_proc_maybe_warn_attribute_conflict(module_info::in,
pred_id::in, proc_info::in, list(error_spec)::in, list(error_spec)::out)
is det.
simplify_proc_maybe_warn_attribute_conflict(ModuleInfo, PredId, ProcInfo,
!Specs) :-
module_info_pred_info(ModuleInfo, PredId, PredInfo),
pred_info_get_markers(PredInfo, Markers),
% The alternate goal by definition cannot be a call_foreign_proc.
proc_info_get_goal(ProcInfo, Goal),
Goal = hlds_goal(GoalExpr, GoalInfo),
( if GoalExpr = call_foreign_proc(Attributes, _, _, _, _, _, _) then
Context = goal_info_get_context(GoalInfo),
MaybeMayDuplicate = get_may_duplicate(Attributes),
(
MaybeMayDuplicate = yes(MayDuplicate),
maybe_warn_about_may_duplicate_attributes(MayDuplicate, Markers,
Context, !Specs)
;
MaybeMayDuplicate = no
),
MaybeMayExportBody = get_may_export_body(Attributes),
(
MaybeMayExportBody = yes(MayExportBody),
maybe_warn_about_may_export_body_attribute(MayExportBody, Markers,
Context, !Specs)
;
MaybeMayExportBody = no
)
else
true
).
:- pred maybe_warn_about_may_duplicate_attributes(proc_may_duplicate::in,
pred_markers::in, prog_context::in,
list(error_spec)::in, list(error_spec)::out) is det.
maybe_warn_about_may_duplicate_attributes(MayDuplicate, Markers, Context,
!Specs) :-
(
MayDuplicate = proc_may_duplicate,
( if check_marker(Markers, marker_user_marked_no_inline) then
Pieces = [words("Error: the"), quote("may_duplicate"),
words("attribute on the foreign_proc contradicts the"),
quote("no_inline"), words("pragma on the predicate.")],
Spec = simplest_spec($pred, severity_error,
phase_simplify(report_in_any_mode), Context, Pieces),
!:Specs = [Spec | !.Specs]
else
true
)
;
MayDuplicate = proc_may_not_duplicate,
( if check_marker(Markers, marker_user_marked_inline) then
Pieces = [words("Error: the"), quote("may_not_duplicate"),
words("attribute on the foreign_proc contradicts the"),
quote("inline"), words("pragma on the predicate.")],
Spec = simplest_spec($pred, severity_error,
phase_simplify(report_in_any_mode), Context, Pieces),
!:Specs = [Spec | !.Specs]
else
true
)
).
:- pred maybe_warn_about_may_export_body_attribute(proc_may_export_body::in,
pred_markers::in, prog_context::in,
list(error_spec)::in, list(error_spec)::out) is det.
maybe_warn_about_may_export_body_attribute(MayExportBody, Markers, Context,
!Specs) :-
(
MayExportBody = proc_may_export_body,
( if check_marker(Markers, marker_user_marked_no_inline) then
Pieces = [words("Error: the"), quote("may_export_body"),
words("attribute on the foreign_proc contradicts the"),
quote("no_inline"), words("pragma on the predicate.")],
Spec = simplest_spec($pred, severity_error,
phase_simplify(report_in_any_mode), Context, Pieces),
!:Specs = [Spec | !.Specs]
else
true
)
;
MayExportBody = proc_may_not_export_body
% Inlining is allowed within the same target file.
).
%-----------------------------------------------------------------------------%
:- pred simplify_top_level_goal(hlds_goal::in, hlds_goal::out,
simplify_nested_context::in, instmap::in,
simplify_info::in, simplify_info::out) is det.
simplify_top_level_goal(!Goal, NestedContext0, InstMap0, !Info) :-
% Simplification is done in two passes, which is we have two calls to
% do_simplify_top_level_goal below. The first pass performs common
% structure and duplicate call elimination. The second pass performs
% excess assignment elimination, and cleans up the code after the
% first pass.
%
% Two passes are required because some parts of the first pass can
% obsolete existing nonlocals sets and instmap deltas, while some parts
% of the second pass may need this information to be up-to-date.
% Therefore we have to be prepared to recompute this information
% between the two passes.
some [!SimplifyTasks] (
simplify_info_get_simplify_tasks(!.Info, !:SimplifyTasks),
OriginalSimplifyTasks = !.SimplifyTasks,
( if
( !.SimplifyTasks ^ do_opt_common_structs = opt_common_structs
; !.SimplifyTasks ^ do_opt_const_structs = opt_const_structs
; !.SimplifyTasks ^ do_opt_duplicate_calls = opt_dup_calls
)
then
!SimplifyTasks ^ do_mark_code_model_changes
:= do_not_mark_code_model_changes,
!SimplifyTasks ^ do_excess_assign := do_not_elim_excess_assigns,
simplify_info_set_simplify_tasks(!.SimplifyTasks, !Info),
do_simplify_top_level_goal(!Goal, NestedContext0, InstMap0, !Info),
!:SimplifyTasks = OriginalSimplifyTasks,
% Disable the generation of error, warning and info messages
% for the second pass.
% - We can do this because any warnings we want to generate
% will have been generated by the first pass.
% - And we *must* do this, because the excess assign transformation
% in pass 2 may replace a variable (say X) with a different
% variable (say Y). So if in pass 1, we generated e.g. a message
% involving X, then in pass 2 we would generate a version
% of that same message, but referring to Y instead of X,
% which is very likely to confuse the reader.
simplify_info_set_allow_messages(do_not_allow_messages, !Info),
% If requested, these tasks were done in pass 1. Repeating them
% in pass 2 would serve no purpose, since we do nothing in pass 1
% that would generate new occurrences of the situations
% that these tasks seek to optimize.
!SimplifyTasks ^ do_opt_common_structs :=
do_not_opt_common_structs,
!SimplifyTasks ^ do_opt_const_structs := do_not_opt_const_structs,
!SimplifyTasks ^ do_opt_duplicate_calls := do_not_opt_dup_calls,
simplify_info_reinit(!.SimplifyTasks, !Info)
else
true
),
% On the second pass do excess assignment elimination and
% some cleaning up after the common structure pass.
do_simplify_top_level_goal(!Goal, NestedContext0, InstMap0, !Info),
simplify_info_get_found_contains_trace(!.Info, FoundContainsTrace),
(
FoundContainsTrace = no
;
FoundContainsTrace = yes,
set_goal_contains_trace_features_in_goal(!Goal, _)
)
% We do not have to put OriginalSimplifyTasks back into !:Info
% at the end, because neither of our two callers will look at
% the tasks field of the !:Info value we return. We could return
% just the fields they *do* look at, but there are many of them.
).
:- pred do_simplify_top_level_goal(hlds_goal::in, hlds_goal::out,
simplify_nested_context::in, instmap::in,
simplify_info::in, simplify_info::out) is det.
do_simplify_top_level_goal(!Goal, NestedContext0, InstMap0, !Info) :-
!.Goal = hlds_goal(_, GoalInfo0),
simplify_info_get_simplify_tasks(!.Info, SimplifyTasks),
Common0 = common_info_init(SimplifyTasks),
simplify_goal(!Goal, NestedContext0, InstMap0, Common0, _Common, !Info),
maybe_recompute_fields_after_top_level_goal(GoalInfo0, InstMap0,
!Goal, !Info).
:- pred maybe_recompute_fields_after_top_level_goal(hlds_goal_info::in,
instmap::in, hlds_goal::in, hlds_goal::out,
simplify_info::in, simplify_info::out) is det.
maybe_recompute_fields_after_top_level_goal(GoalInfo0, InstMap0,
!Goal, !Info) :-
simplify_info_get_rerun_quant_instmap_delta(!.Info, RerunQuantDelta),
(
RerunQuantDelta = rerun_quant_instmap_deltas,
NonLocals = goal_info_get_nonlocals(GoalInfo0),
some [!VarTable, !RttiVarMaps, !ModuleInfo] (
simplify_info_get_var_table(!.Info, !:VarTable),
simplify_info_get_rtti_varmaps(!.Info, !:RttiVarMaps),
implicitly_quantify_goal_general(ord_nl_maybe_lambda, NonLocals, _,
!Goal, !VarTable, !RttiVarMaps),
simplify_info_set_var_table(!.VarTable, !Info),
simplify_info_set_rtti_varmaps(!.RttiVarMaps, !Info),
% Always recompute instmap_deltas for atomic goals - this is safer
% in the case where unused variables should no longer be included
% in the instmap_delta for a goal.
simplify_info_get_module_info(!.Info, !:ModuleInfo),
simplify_info_get_inst_varset(!.Info, InstVarSet),
recompute_instmap_delta(recomp_atomics, !.VarTable, InstVarSet,
InstMap0, !Goal, !ModuleInfo),
simplify_info_set_module_info(!.ModuleInfo, !Info)
)
;
RerunQuantDelta = do_not_rerun_quant_instmap_deltas
),
simplify_info_get_rerun_det(!.Info, RerunDet),
(
RerunDet = rerun_det,
Detism = goal_info_get_determinism(GoalInfo0),
some [!VarTable, !RttiVarMaps, !ModuleInfo, !ProcInfo]
(
det_get_soln_context(Detism, SolnContext),
% Det_infer_goal looks up the proc_info in the module_info for
% the var_table, so we have to put them back in the module_info.
simplify_info_get_module_info(!.Info, !:ModuleInfo),
simplify_info_get_var_table(!.Info, !:VarTable),
simplify_info_get_rtti_varmaps(!.Info, !:RttiVarMaps),
simplify_info_get_pred_proc_id(!.Info, PredProcId),
module_info_pred_proc_info(!.ModuleInfo, PredProcId,
PredInfo, !:ProcInfo),
proc_info_set_var_table(!.VarTable, !ProcInfo),
proc_info_set_rtti_varmaps(!.RttiVarMaps, !ProcInfo),
module_info_set_pred_proc_info(PredProcId,
PredInfo, !.ProcInfo, !ModuleInfo),
simplify_info_set_module_info(!.ModuleInfo, !Info),
det_info_init(!.ModuleInfo, PredProcId, !.VarTable,
pess_extra_vars_report, [], DetInfo0),
det_infer_goal(!Goal, InstMap0, SolnContext, [], no,
_, _, DetInfo0, DetInfo),
det_info_get_module_info(DetInfo, !:ModuleInfo),
det_info_get_var_table(DetInfo, !:VarTable),
simplify_info_set_module_info(!.ModuleInfo, !Info),
simplify_info_set_var_table(!.VarTable, !Info)
)
;
RerunDet = do_not_rerun_det
).
% The call to simplify_info_reinit in our caller will reset !:Info
% to do_not_rerun_quant_instmap_deltas and do_not_rerun_det before
% the next pass, if there is a next pass.
%-----------------------------------------------------------------------------%
:- pred set_goal_contains_trace_features_in_goal(hlds_goal::in, hlds_goal::out,
contains_trace_goal::out) is det.
set_goal_contains_trace_features_in_goal(Goal0, Goal, ContainsTrace) :-
Goal0 = hlds_goal(GoalExpr0, GoalInfo0),
(
( GoalExpr0 = unify(_, _, _, _, _)
; GoalExpr0 = plain_call(_, _, _, _, _, _)
; GoalExpr0 = generic_call(_, _, _, _, _)
; GoalExpr0 = call_foreign_proc(_, _, _, _, _, _, _)
),
GoalExpr = GoalExpr0,
ContainsTrace = contains_no_trace_goal
;
GoalExpr0 = conj(ConjType, SubGoals0),
ContainsTrace0 = contains_no_trace_goal,
set_goal_contains_trace_features_in_goals(SubGoals0, SubGoals,
ContainsTrace0, ContainsTrace),
GoalExpr = conj(ConjType, SubGoals)
;
GoalExpr0 = disj(SubGoals0),
ContainsTrace0 = contains_no_trace_goal,
set_goal_contains_trace_features_in_goals(SubGoals0, SubGoals,
ContainsTrace0, ContainsTrace),
GoalExpr = disj(SubGoals)
;
GoalExpr0 = switch(SwitchVar, CanFail, Cases0),
ContainsTrace0 = contains_no_trace_goal,
set_goal_contains_trace_features_in_cases(Cases0, Cases,
ContainsTrace0, ContainsTrace),
GoalExpr = switch(SwitchVar, CanFail, Cases)
;
GoalExpr0 = if_then_else(Vars, Cond0, Then0, Else0),
set_goal_contains_trace_features_in_goal(Cond0, Cond,
CondContainsTrace),
set_goal_contains_trace_features_in_goal(Then0, Then,
ThenContainsTrace),
set_goal_contains_trace_features_in_goal(Else0, Else,
ElseContainsTrace),
GoalExpr = if_then_else(Vars, Cond, Then, Else),
ContainsTrace = worst_contains_trace(CondContainsTrace,
worst_contains_trace(ThenContainsTrace, ElseContainsTrace))
;
GoalExpr0 = negation(SubGoal0),
set_goal_contains_trace_features_in_goal(SubGoal0, SubGoal,
ContainsTrace),
GoalExpr = negation(SubGoal)
;
GoalExpr0 = scope(Reason, SubGoal0),
(
Reason = trace_goal(_, _, _, _, _),
SubGoal = SubGoal0,
ContainsTrace = contains_trace_goal
;
Reason = from_ground_term(_, FGT),
(
( FGT = from_ground_term_construct
; FGT = from_ground_term_deconstruct
),
SubGoal = SubGoal0,
ContainsTrace = contains_no_trace_goal
;
( FGT = from_ground_term_initial
; FGT = from_ground_term_other
),
set_goal_contains_trace_features_in_goal(SubGoal0, SubGoal,
ContainsTrace)
)
;
( Reason = exist_quant(_, _)
; Reason = disable_warnings(_, _)
; Reason = promise_solutions(_, _)
; Reason = promise_purity(_)
; Reason = require_detism(_)
; Reason = require_complete_switch(_)
; Reason = require_switch_arms_detism(_, _)
; Reason = commit(_)
; Reason = barrier(_)
; Reason = loop_control(_, _, _)
),
set_goal_contains_trace_features_in_goal(SubGoal0, SubGoal,
ContainsTrace)
),
GoalExpr = scope(Reason, SubGoal)
;
GoalExpr0 = shorthand(ShortHand0),
(
ShortHand0 = atomic_goal(GoalType, Outer, Inner, MaybeOutputVars,
MainGoal0, OrElseGoals0, OrElseInners),
set_goal_contains_trace_features_in_goal(MainGoal0, MainGoal,
MainContainsTrace),
OrElseContainsTrace0 = contains_no_trace_goal,
set_goal_contains_trace_features_in_goals(
OrElseGoals0, OrElseGoals,
OrElseContainsTrace0, OrElseContainsTrace),
ShortHand = atomic_goal(GoalType, Outer, Inner, MaybeOutputVars,
MainGoal, OrElseGoals, OrElseInners),
GoalExpr = shorthand(ShortHand),
ContainsTrace = worst_contains_trace(MainContainsTrace,
OrElseContainsTrace)
;
ShortHand0 = try_goal(MaybeIO, ResultVar, SubGoal0),
set_goal_contains_trace_features_in_goal(SubGoal0, SubGoal,
ContainsTrace),
ShortHand = try_goal(MaybeIO, ResultVar, SubGoal),
GoalExpr = shorthand(ShortHand)
;
ShortHand0 = bi_implication(_, _),
unexpected($pred, "bi_implication")
)
),
(
ContainsTrace = contains_trace_goal,
goal_info_add_feature(feature_contains_trace, GoalInfo0, GoalInfo)
;
ContainsTrace = contains_no_trace_goal,
goal_info_remove_feature(feature_contains_trace, GoalInfo0, GoalInfo)
),
Goal = hlds_goal(GoalExpr, GoalInfo).
:- pred set_goal_contains_trace_features_in_goals(
list(hlds_goal)::in, list(hlds_goal)::out,
contains_trace_goal::in, contains_trace_goal::out) is det.
set_goal_contains_trace_features_in_goals([], [], !ContainsTrace).
set_goal_contains_trace_features_in_goals([Goal0 | Goals0], [Goal | Goals],
!ContainsTrace) :-
set_goal_contains_trace_features_in_goal(Goal0, Goal, GoalContainsTrace),
!:ContainsTrace = worst_contains_trace(GoalContainsTrace, !.ContainsTrace),
set_goal_contains_trace_features_in_goals(Goals0, Goals, !ContainsTrace).
:- pred set_goal_contains_trace_features_in_cases(
list(case)::in, list(case)::out,
contains_trace_goal::in, contains_trace_goal::out) is det.
set_goal_contains_trace_features_in_cases([], [], !ContainsTrace).
set_goal_contains_trace_features_in_cases([Case0 | Cases0], [Case | Cases],
!ContainsTrace) :-
Case0 = case(MainConsId, OtherConsIds, Goal0),
set_goal_contains_trace_features_in_goal(Goal0, Goal, GoalContainsTrace),
Case = case(MainConsId, OtherConsIds, Goal),
!:ContainsTrace = worst_contains_trace(GoalContainsTrace, !.ContainsTrace),
set_goal_contains_trace_features_in_cases(Cases0, Cases, !ContainsTrace).
%-----------------------------------------------------------------------------%
:- end_module check_hlds.simplify.simplify_proc.
%-----------------------------------------------------------------------------%