Files
mercury/compiler/goal_path.m
Zoltan Somogyi 672f77c4ec Add a new compiler option. --inform-ite-instead-of-switch.
Estimated hours taken: 20
Branches: main

Add a new compiler option. --inform-ite-instead-of-switch. If this is enabled,
the compiler will generate informational messages about if-then-elses that
it thinks should be converted to switches for the sake of program reliability.

Act on the output generated by this option.

compiler/simplify.m:
	Implement the new option.

	Fix an old bug that could cause us to generate warnings about code
	that was OK in one duplicated copy but not in another (where a switch
	arm's code is duplicated due to the case being selected for more than
	one cons_id).

compiler/options.m:
	Add the new option.

	Add a way to test for the bug fix in simplify.

doc/user_guide.texi:
	Document the new option.

NEWS:
	Mention the new option.

library/*.m:
mdbcomp/*.m:
browser/*.m:
compiler/*.m:
deep_profiler/*.m:
	Convert if-then-elses to switches at most of the sites suggested by the
	new option. At the remaining sites, switching to switches would have
	nontrivial downsides. This typically happens with the switched-on type
	has many functors, and we treat one or two specially (e.g. cons/2 in
	the cons_id type).

	Perform misc cleanups in the vicinity of the if-then-else to switch
	conversions.

	In a few cases, improve the error messages generated.

compiler/accumulator.m:
compiler/hlds_goal.m:
	(Rename and) move insts for particular kinds of goal from
	accumulator.m to hlds_goal.m, to allow them to be used in other
	modules. Using these insts allowed us to eliminate some if-then-elses
	entirely.

compiler/exprn_aux.m:
	Instead of fixing some if-then-elses, delete the predicates containing
	them, since they aren't used, and (as pointed out by the new option)
	would need considerable other fixing if they were ever needed again.

compiler/lp_rational.m:
	Add prefixes to the names of the function symbols on some types,
	since without those prefixes, it was hard to figure out what type
	the switch corresponding to an old if-then-else was switching on.

tests/invalid/reserve_tag.err_exp:
	Expect a new, improved error message.
2007-11-23 07:36:01 +00:00

258 lines
9.5 KiB
Mathematica

%-----------------------------------------------------------------------------%
% vim: ft=mercury ts=4 sw=4 et
%-----------------------------------------------------------------------------%
% Copyright (C) 1997-2007 University of Melbourne.
% This file may only be copied under the terms of the GNU General
% Public License - see the file COPYING in the Mercury distribution.
%-----------------------------------------------------------------------------%
%
% File: goal_path.m.
% Main author: zs.
%
% This module looks after goal paths, which associate each goal with its
% position in a procedure definition,
%
%-----------------------------------------------------------------------------%
%-----------------------------------------------------------------------------%
:- module check_hlds.goal_path.
:- interface.
:- import_module hlds.
:- import_module hlds.hlds_goal.
:- import_module hlds.hlds_pred.
:- import_module hlds.hlds_module.
:- import_module parse_tree.
:- import_module parse_tree.prog_data.
:- import_module bool.
%-----------------------------------------------------------------------------%
% IMPORTANT: the type constraint_id in hlds_data.m makes use of
% goal_paths to identify constraints between the typechecking pass
% and the polymorphism pass. For this reason, goal paths should not
% be recalculated anywhere between these two passes. See the XXX
% comment near the declaration of constraint_id.
%
:- pred fill_goal_path_slots(module_info::in, proc_info::in, proc_info::out)
is det.
% Fill in the goal_paths for goals in the clauses_info of the predicate.
% Clauses are given goal paths `disj(1)', ..., `disj(N)'. If the bool
% argument is true then the goal paths are stored in a form where any
% prefix consisting of `disj(_)', `neg', `exist(_)' and `ite_else'
% components is removed. This is used to optimise the constraint-based
% mode analysis where the instantiatedness of a variable at such a goal
% path is always equivalent to its instantiatedness at the parent goal
% path.
%
:- pred fill_goal_path_slots_in_clauses(module_info::in, bool::in,
pred_info::in, pred_info::out) is det.
:- pred fill_goal_path_slots_in_goal(hlds_goal::in, vartypes::in,
module_info::in, hlds_goal::out) is det.
%-----------------------------------------------------------------------------%
%-----------------------------------------------------------------------------%
:- implementation.
:- import_module check_hlds.type_util.
:- import_module hlds.hlds_clauses.
:- import_module hlds.hlds_goal.
:- import_module libs.
:- import_module libs.compiler_util.
:- import_module mdbcomp.
:- import_module mdbcomp.program_representation.
:- import_module parse_tree.prog_data.
:- import_module cord.
:- import_module int.
:- import_module list.
:- import_module map.
:- import_module maybe.
:- import_module pair.
%-----------------------------------------------------------------------------%
:- type slot_info
---> slot_info(
vartypes :: vartypes,
module_info :: module_info,
omit_mode_equiv_prefix :: bool
).
fill_goal_path_slots(ModuleInfo, !Proc) :-
proc_info_get_goal(!.Proc, Goal0),
proc_info_get_vartypes(!.Proc, VarTypes),
fill_goal_path_slots_in_goal(Goal0, VarTypes, ModuleInfo, Goal),
proc_info_set_goal(Goal, !Proc).
fill_goal_path_slots_in_clauses(ModuleInfo, OmitModeEquivPrefix, !PredInfo) :-
pred_info_get_clauses_info(!.PredInfo, ClausesInfo0),
clauses_info_clauses_only(ClausesInfo0, Clauses0),
clauses_info_get_vartypes(ClausesInfo0, VarTypes),
SlotInfo = slot_info(VarTypes, ModuleInfo, OmitModeEquivPrefix),
list.map_foldl(fill_slots_in_clause(SlotInfo), Clauses0, Clauses, 1, _),
clauses_info_set_clauses(Clauses, ClausesInfo0, ClausesInfo),
pred_info_set_clauses_info(ClausesInfo, !PredInfo).
:- pred fill_slots_in_clause(slot_info::in, clause::in, clause::out,
int::in, int::out) is det.
fill_slots_in_clause(SlotInfo, Clause0, Clause, ClauseNum, ClauseNum + 1) :-
Clause0 = clause(ProcIds, Goal0, Lang, Context),
fill_goal_slots(cord.singleton(step_disj(ClauseNum)), SlotInfo,
Goal0, Goal),
Clause = clause(ProcIds, Goal, Lang, Context).
fill_goal_path_slots_in_goal(Goal0, VarTypes, ModuleInfo, Goal) :-
SlotInfo = slot_info(VarTypes, ModuleInfo, no),
fill_goal_slots(empty, SlotInfo, Goal0, Goal).
:- pred fill_goal_slots(goal_path::in, slot_info::in,
hlds_goal::in, hlds_goal::out) is det.
fill_goal_slots(Path0, SlotInfo,
hlds_goal(Expr0, Info0), hlds_goal(Expr, Info)) :-
OmitModeEquivPrefix = SlotInfo ^ omit_mode_equiv_prefix,
(
OmitModeEquivPrefix = yes,
PathSteps0 = cord.list(Path0),
list.takewhile(mode_equiv_step, PathSteps0, _, PathSteps),
Path = cord.from_list(PathSteps)
;
OmitModeEquivPrefix = no,
Path = Path0
),
goal_info_set_goal_path(Path, Info0, Info),
fill_expr_slots(Info, Path0, SlotInfo, Expr0, Expr).
:- pred mode_equiv_step(goal_path_step::in) is semidet.
mode_equiv_step(Step) :-
( Step = step_disj(_)
; Step = step_neg
; Step = step_scope(_)
; Step = step_ite_else
).
:- pred fill_expr_slots(hlds_goal_info::in, goal_path::in, slot_info::in,
hlds_goal_expr::in, hlds_goal_expr::out) is det.
fill_expr_slots(GoalInfo, Path0, SlotInfo, Goal0, Goal) :-
(
Goal0 = conj(ConjType, Goals0),
fill_conj_slots(Path0, 0, SlotInfo, Goals0, Goals),
Goal = conj(ConjType, Goals)
;
Goal0 = disj(Goals0),
fill_disj_slots(Path0, 0, SlotInfo, Goals0, Goals),
Goal = disj(Goals)
;
Goal0 = switch(Var, CanFail, Cases0),
VarTypes = SlotInfo ^ vartypes,
ModuleInfo = SlotInfo ^ module_info,
map.lookup(VarTypes, Var, Type),
( switch_type_num_functors(ModuleInfo, Type, NumFunctors) ->
MaybeNumFunctors = yes(NumFunctors)
;
MaybeNumFunctors = no
),
fill_switch_slots(Path0, 0, MaybeNumFunctors, SlotInfo, Cases0, Cases),
Goal = switch(Var, CanFail, Cases)
;
Goal0 = negation(SubGoal0),
fill_goal_slots(cord.snoc(Path0, step_neg), SlotInfo,
SubGoal0, SubGoal),
Goal = negation(SubGoal)
;
Goal0 = scope(Reason, SubGoal0),
SubGoal0 = hlds_goal(_, InnerInfo),
OuterDetism = goal_info_get_determinism(GoalInfo),
InnerDetism = goal_info_get_determinism(InnerInfo),
( InnerDetism = OuterDetism ->
MaybeCut = scope_is_no_cut
;
MaybeCut = scope_is_cut
),
fill_goal_slots(cord.snoc(Path0, step_scope(MaybeCut)), SlotInfo,
SubGoal0, SubGoal),
Goal = scope(Reason, SubGoal)
;
Goal0 = if_then_else(A, Cond0, Then0, Else0),
fill_goal_slots(cord.snoc(Path0, step_ite_cond), SlotInfo,
Cond0, Cond),
fill_goal_slots(cord.snoc(Path0, step_ite_then), SlotInfo,
Then0, Then),
fill_goal_slots(cord.snoc(Path0, step_ite_else), SlotInfo,
Else0, Else),
Goal = if_then_else(A, Cond, Then, Else)
;
Goal0 = unify(LHS, RHS0, Mode, Kind, Context),
(
RHS0 = rhs_lambda_goal(A, B, C, D, E, F, G, LambdaGoal0),
fill_goal_slots(Path0, SlotInfo, LambdaGoal0, LambdaGoal),
RHS = rhs_lambda_goal(A, B, C, D, E, F, G, LambdaGoal)
;
( RHS0 = rhs_var(_)
; RHS0 = rhs_functor(_, _, _)
),
RHS = RHS0
),
Goal = unify(LHS, RHS, Mode, Kind, Context)
;
Goal0 = plain_call(_, _, _, _, _, _),
Goal = Goal0
;
Goal0 = generic_call(_, _, _, _),
Goal = Goal0
;
Goal0 = call_foreign_proc(_, _, _, _, _, _, _),
Goal = Goal0
;
Goal0 = shorthand(_),
% These should have been expanded out by now.
unexpected(this_file, "fill_expr_slots: unexpected shorthand")
).
:- pred fill_conj_slots(goal_path::in, int::in, slot_info::in,
list(hlds_goal)::in, list(hlds_goal)::out) is det.
fill_conj_slots(_, _, _, [], []).
fill_conj_slots(Path0, N0, SlotInfo, [Goal0 | Goals0], [Goal | Goals]) :-
N1 = N0 + 1,
fill_goal_slots(cord.snoc(Path0, step_conj(N1)), SlotInfo, Goal0, Goal),
fill_conj_slots(Path0, N1, SlotInfo, Goals0, Goals).
:- pred fill_disj_slots(goal_path::in, int::in, slot_info::in,
list(hlds_goal)::in, list(hlds_goal)::out) is det.
fill_disj_slots(_, _, _, [], []).
fill_disj_slots(Path0, N0, SlotInfo, [Goal0 | Goals0], [Goal | Goals]) :-
N1 = N0 + 1,
fill_goal_slots(cord.snoc(Path0, step_disj(N1)), SlotInfo, Goal0, Goal),
fill_disj_slots(Path0, N1, SlotInfo, Goals0, Goals).
:- pred fill_switch_slots(goal_path::in, int::in, maybe(int)::in,
slot_info::in, list(case)::in, list(case)::out) is det.
fill_switch_slots(_, _, _, _, [], []).
fill_switch_slots(Path0, N0, MaybeNumFunctors, SlotInfo,
[case(ConsId, Goal0) | Cases0], [case(ConsId, Goal) | Cases]) :-
N1 = N0 + 1,
fill_goal_slots(cord.snoc(Path0, step_switch(N1, MaybeNumFunctors)),
SlotInfo, Goal0, Goal),
fill_switch_slots(Path0, N1, MaybeNumFunctors, SlotInfo, Cases0, Cases).
%-----------------------------------------------------------------------------%
:- func this_file = string.
this_file = "goal_path.m".
%-----------------------------------------------------------------------------%
:- end_module goal_path.
%-----------------------------------------------------------------------------%