3 Commits

Author	SHA1	Message	Date
Zoltan Somogyi	dd44e0ef62	Replace the "set" command of mdb with a bunch of commands: the `format', ... Estimated hours taken: 16 Branches: main, release Replace the "set" command of mdb with a bunch of commands: the `format', `format_param', `list_context_lines', `list_path', `xml_browser_cmd', `xml_tmp_filename', `fail_trace_counts', `pass_trace_counts' and `max_io_actions' commands. Each of these set just one parameter or one of set of closely related parameters. Move all these commands, and some existing commands that set parameters that were elsewhere, to the "parameter" command category. Extend some of these commands so that if given no arguments, they report the current values of the parameters they would otherwise set. Replace the "set" commands of the mdb browser and of the declarative debugger with a bunch of commands: "format", "depth", "size", "width", "lines", "actions" and "params" (the last prints the current value of the parameters). For each category of mdb commands, create files mercury_trace_cmd_<cat>.[ch], and move the functions dealing with that category of commands there from mercury_trace_internal.c. Give each of these new files a logical structure that was sometimes missing from the relevant parts of mercury_trace_internal.c. NEWS: Mention these changes. doc/mdb_categories: Document these changes. doc/user_guide.texi: Document these changes. Fix an old documentation bug: you couldn't set listing paramaters from a declarative debugger command. Fix an old documentation bug: the description of the goal_path step for scopes was obsolete. Fix some obsolete references to : as module qualifier. browser/parse.m: Update the browser command set along the lines at the top. browser/declarative_user.m: Update the declarative debugger command set along the lines at the top. Move the declaration for the type representing declarative debugger commands to near the top of the file. browser/browser_info.m: Provide some access predicates. Update the predicate that generates mdb commands to save the persistent state of the debugger to generate the new forms of parameter commands. Move types and predicates for dealing with browser parameters from browse.m to here, so that declarative_user.m can use them too. browser/browse.m: Delete the code moved to browser_info.m, and conform to the other changes in the other modules. browser/listing.m: Provide a predicate to return the type of listing paths. scripts/mdbrc.in: Update the commands that set the XML parameters. scripts/Mmakefile: Get mmake to rebuild mdbrc from mdbrc.in when mdbrc.in changes. trace/mercury_trace_internal.c: trace/mercury_trace_cmds.h: trace/mercury_trace_cmd_*.[ch]: Implement the changes described at the top. Fix an old bug: the commands that update the search path for the "list" command don't make the search path term permanent, which is needed in non-conservative-gc grades. trace/mercury_trace_spy.c: Fix some obsolete references to : as module qualifier. trace/mercury_trace_browse.[ch]: Delete the functionality now moved to mercury_trace_cmd_parameter.c. tests/debugger/mdb_command_test.inp: Update the set of commands being tested. tests/debugger/save.{inp,exp}: Update the parameter commands in this test case.	2006-04-04 07:37:31 +00:00
Ian MacLarty	136cae8302	Fix some debugger test cases failing in grade decldebug because the library is ... Estimated hours taken: 1 Branches: main Fix some debugger test cases failing in grade decldebug because the library is deep traced in that grade. tests/debugger/Mmakefile Set INP variable to inp2 for decldebug grade, so loopcheck can have different input in this grade. tests/debugger/all_solutions.exp4 tests/debugger/exception_cmd.exp3 tests/debugger/print_table.exp3 tests/debugger/retry.exp3 New expected outputs with the only differences the event and depth number of some events. tests/debugger/exception_value.exp3 This expected output had its print format set to verbose for some reason, so overwrote this expected output with new output with flat format (the default) and new depth/event numbers for decldebug grade. tests/debugger/polymorphic_output.exp3 This expected output still used the non-standardized event printing, even though the test is run with standardized event printing. So replaced this expected outout file with the decldebug expected output. tests/debugger/loopcheck.exp3 tests/debugger/loopcheck.inp2 Add new input that only prints events in loopcheck module, otherwise there are just way too many events printed.	2004-11-10 02:21:40 +00:00
Zoltan Somogyi	168500343c	This change adds new facilities for debugging minimal model tabling, and ... Estimated hours taken: 160 Branches: main This change adds new facilities for debugging minimal model tabling, and has several bug fixes found with the aid of those facilities. Most of the diff affects the behavior of the system only in minimal model grades and/or when debugging flags are defined. compiler/ite_gen.m: In minimal model grades, surround the conditions of if-then-elses with calls to three functions. These functions detect when a condition fails due to one or more suspensions, and abort the program. (After resumptions, the condition may actually have solutions, but by then the computation has committed to the wrong path.) compiler/table_gen.m: Change the program transformation for model_non predicates to use a switch instead of nested if-then-elses, to avoid the overhead of wrapping the condition. The version with switches is also a bit easier to debug. The transformation for model_det and model_semi predicates stays as before, because for such predicates finding the status (which we want to switch on) requires computation, not just a lookup. Switch to state variable syntax in the affected predicates. Make the error message for an internal error in loopcheck predicates more precise. Mark the code fragments that modify tabling data structures as impure and code fragments that examine tabling data structures as semipure. runtime/mercury_stacks.[ch]: Implement the new stack of possibly negated contexts that we use to detect false failures due to suspensions in negated contexts. Fix a bug: don't refer to MR_cut_stack[-1]. Shorten the name of the generator stack. runtime/mercury_context.[ch]: runtime/mercury_memory.c: runtime/mercury_wrapper.[ch]: Allocate memory for the new stack of possibly negated contexts. Use the shortened name of the generator stack. runtime/mercury_regorder.h: Allocate a pointer for the new stack of possibly negated contexts. runtime/mercury_minimal_model.[ch]: A new module holding the part of mercury_tabling.[ch] that is specific to minimal model tabling. This version contains tools to help debugging of minimal model tabling, as well as some bug fixes found with the aid of those tools. runtime/mercury_tabling.[ch]: Remove the code moved to mercury_minimal_model.[ch], and add the code moved here from trace/mercury_trace_internal.c. Add prefixes to a bunch of structure fields to make it easier to read code accessing those fields. Add mechanisms to allocate and copy tabling structures with type safety. runtime/mercury_imp.h: #include the new header file, if it is needed. runtime/Mmakefile: Mention the new module, and fix sortedness errors. runtime/mercury_stack_trace.c: Fix a bug that sometimes caused stack traces to abort in minimal model grades: they were trying to get layout information from labels that do not have them, such as do_fail. If MR_TABLE_DEBUG is defined, print the locations of stack frames when doing stack dumps. runtime/mercury_trace_base.h: Export to mercury_stack_trace.c the labels that we use to let the debugger get control at redos and fails, since they don't have layout information. runtime/mercury_types.h: Move typedefs here from mercury_tabling.h, and add typedefs for some newly added types. runtime/mercury_engine.[ch]: Add a table mapping debugging flags to their offsets in the MR_debugflag array, for use in the debugger. runtime/mercury_misc.c: Make the formatting of det stack pointers the same as nondet stack pointers in debugging output. runtime/mercury_debug.[ch]: Add conditionally compiled debugging output when creating temp frames on the nondet stack. library/table_builtin.m: Conform to the new names of some fields. Add a predicate to return the status of a subgoal. Add conditionally compiled debugging code. library/Mmakefile: Make table_builtin.m depend on runtime/mercury_minimal_model.h. trace/mercury_trace.c: Conform to the new names of some fields. trace/mercury_trace_internal.c: Add two new mdb commands, to print the cut stack and the new possibly negated context stack. Add two new mdb commands to print a subgoal and a consumer. Move some of the code to print tabling-related data structures to runtime/mercury_tabling.[ch]. Add a new mdb command to report the values of debugging flags and to set and clear them. Previously, one had to turn on these debugging flags with environment variables, which were problematic because they turned on diagnostic printouts even in Mercury programs that *weren't* being debugged, such as the Mercury compiler when being used to generate the program to be debugged. Now the flags can be turned on from a .mdbrc file, which eliminates much setting and unsetting of environment variables. doc/user_guide.tex: Document the new mdb commands. tests/debugger/mdb_command_test.inp: Test the documentation of the new mdb commands. tests/debugger/completion.exp: Expect the new commands in the command completion test. tests/debugger//nondet_stack.exp*: Expect the new format of det stack pointers. tests/debugger/all_solutions.exp3: tests/debugger/exception_value.exp3: tests/debugger/declarative/catch.exp3: tests/debugger/declarative/ho5.exp3: tests/debugger/declarative/throw.exp3: New expected test cases for use in minimal model grades. They differ from existing expected output files only in the precise phrasing of error messages. tests/debugger/declarative/Mmakefile: Disable the untraced_subgoal test case in .mm grades, since we don't pass it yet. tests/tabling/Mmakefile: Enable the mday test case, now that we pass it.	2003-03-18 16:39:01 +00:00