3 Commits

Author	SHA1	Message	Date
Zoltan Somogyi	8827b6a466	Make --halt-at-invalid-interface the default. ... NEWS: Mention this fact. Group related changes together. Fix some typos. compiler/error_util.m: Let the halt_at_invalid_interface option govern whether we print error messages when we generate .int/.int2 files, rather than the print_errors_warnings_when_generating_interface option. This simplifies the use of that option. compiler/options.m: doc/user_guide.texi: Document the halt_at_invalid_interface option. Delete the print_errors_warnings_when_generating_interface option, since its functionality has been subsumed into halt_at_invalid_interface. compiler/grab_modules.m: Check the accessibility of imported modules not just when generating target language code, but also when generating .int/.int2 files. Without this, the test_nested test case, which this diff moves from invalid to invalid_make_int, would miss out on some errors being reported in its new home. To make the above possible, refactor the code that does the check to let it work on aug_make_int_units as well as from aug_compilation_units. Make the wording of any error message depend on where the info came from, because unlike aug_comp_units, aug_make_int_units work with an known-incomplete picture of the relevant info. Update some obsolete comments. compiler/write_module_interface_files.m: Add a comment about a design decision that affects this diff. tests/invalid_make_int/Mercury.options: tests/invalid_make_int/Mmakefile: Add to this directory's list the test cases that this diff moves to this directory from other test directories, because the errors that they test for are now reported at interface generation time. Fix the rule handling multimodule tests, now that we have some :-( Specify -j1 for this directory, since the two tests moved here from invalid_submodules include nested submodules. tests/invalid_make_int/bad_type_class_constraint_intermodule.{m,int_err_exp}: Move this test case here from invalid, renaming files slightly, and update the expected output. tests/invalid_make_int/bug499.{m,int_err_exp}: Move this test case here from invalid, and update the expected output. tests/invalid_make_int/int_impl_imports.{m,int_err_exp}: tests/invalid_make_int/int_impl_imports_2.m: Move this test case here from invalid, and update the expected output. tests/invalid_make_int/missing_interface_import2.{m,int_err_exp}: tests/invalid_make_int/missing_interface_import3.m: Move this test case here from invalid, and update the expected output. tests/invalid_make_int/missing_parent_import.{m,int_err_exp}: tests/invalid_make_int/children.m: tests/invalid_make_int/children2.m: Move this test case here from invalid_submodules, and update the expected output. tests/invalid_make_int/sub_c.{m,int_err_exp}: tests/invalid_make_int/sub_a.m: Move this test case here from invalid_submodules, and update the expected output. tests/invalid_make_int/test_nested.{m,int_err_exp}: tests/invalid_make_int/parent.m: tests/invalid_make_int/parent.private_child.m: tests/invalid_make_int/parent.public_child.m: tests/invalid_make_int/parent.undeclared_child.m: tests/invalid_make_int/parent2.child.m: tests/invalid_make_int/parent2.m: Move this test case here from invalid, and update the expected output. tests/invalid_make_int/transitive_import.{m,int_err_exp}: Move this test case here from invalid, update it, and update the expected output. tests/invalid/Mmakefile: Delete from the list of tests in this directory the tests moved to invalid_make_int, and test bug521. tests/invalid/bug521.{m,err_exp}: tests/invalid/bug521_sub.m: Delete this test. invalid_make_int already had a copy of the relevant part of this test. tests/invalid_submodules/Mmakefile: Delete from the list of tests in this directory the two tests moved to invalid_make_int. Delete from the list of tests in this directory two other tests for which we now detect some or all of the errors tested for at interface generation time, but which are already covered by other tests. tests/valid_make_int/Mmakefile: Delete from the list of tests in this directory the test moved to invalid_make_int. (We could successfully generate a .int file for that test case *only if* we did not check it for errors :-) tests/valid_seq/intermod_nested_module_bug2.m: tests/valid_seq/intermod_nested_module_bug2.sub.m: Move two module imports from the parent to the child module, because only the child needs them, and any compiler with this diff will now complain about them being unused in the parent at interface generation time. Delete a third import, which was not used anywhere.	2021-11-20 23:49:19 +11:00
Zoltan Somogyi	21b0e35039	Update the style of the tests in valid_seq.	2020-11-15 08:02:47 +11:00
Zoltan Somogyi	e0cdfc2fe2	Make the tests really work in parallel. ... There was a bug that prevented the tests in each directory from being run in parallel, even when the mmake was invoked with e.g. -j4. The bug was the absence of a '+' on an action that invoked tests/run_one_test. Without that +, the make process inside the "mmake -j4 runtests_local" command issued by bootcheck screwed up its connection with the recursive make invoked by run_one_test, and apparently decided to stop using parallelism. It was telling us this all this time but its messages, which looked like this: make[2]: warning: -jN forced in submake: disabling jobserver mode. were lost in the sea of other bootcheck output until my recent change to run_one_test. A single-character change fixes the bug; the rest of this big change is dealing with the consequences of fixing the bug. Many test cases in the hard_coded and valid directories contain nested modules, which need to be compiled sequentially. tests/Mmake.common: Fix the bug. Delete the duplicate "ALL TESTS SUCCEEDED" message from the runtests target, since the runtests_local target already prints a message to that effect. Make this message more emphatic. tests/run_one_test: Make the output a bit easier to understand. tests/hard_coded/*.{m,exp}: tests/submodules/*.{m,exp}: Move the source files and expected output files of the test cases that use nested modules from hard_coded to submodules, since most of the tests in the hard_coded can be done in parallel, while the ones in submodules are already done in sequence. tests/hard_coded/Mmakefile: tests/hard_coded/Mercury.options: tests/submodules/Mmakefile: tests/submodules/Mercury.options: Move the Mmakefile and Mercury.options entries of the moved test cases from hard_coded to submodules. tests/valid_seq: A new test directory, to hold the test cases originally in tests/valid that contain nested modules. Moving these to a new directory, which forces -j1, allows us to execute the remaining ones in parallel. tests/valid/*.m: tests/valid_seq/*.m: Move the source files of the test cases that use nested modules from valid to valid_seq. In a few cases, clean up the test cases a bit. tests/valid/Mmakefile: tests/valid/Mercury.options: tests/valid_seq/Mmakefile: tests/valid_seq/Mercury.options: tests/valid/Mmake.valid.common: Add valid_seq/Mmakefile to list the test cases now in valid_seq, and add valid_seq/Mercury.options to hold their option values. Delete the entries of those tests from valid/Mmakefile, and their option values from valid/Mercury.options. Unlike valid/Mmakefile, valid_seq/Mmakefile forces -j1. To avoid unnecessary duplication between the two Makefiles, put all the rules that both need into valid/Mmake.valid.common, and include this in both Mmakefiles. tests/string_format/Mmakefile: Force -j1, since these tests share a library module. tests/Mmakefile: List the new valid_seq directory among the others. tests/bootcheck: Execute the tests in the new valid_seq directory as well as the others. Record when the execution of the test suite is started. Comment out invocations of set -x, since they add no useful information in the vast majority of cases. The comment sign can be removed if and when the information *would* be useful. Don't try to copy a nonexistent file. (The error message about this was also lost in the noise.)	2015-08-26 01:01:54 +10:00