2 Commits

Author	SHA1	Message	Date
Zoltan Somogyi	7b82c59c40	Remove unneeded module qualifications from error messages. ... This should make error messages easier to read by removing clutter. compiler/error_util.m: Split each of the sym_name and sym_name_and_arity error pieces into two; one which prints any module qualification present in the given sym_name, and one which does not. This forces people who use these pieces to think about whether they want the sym_name module qualified in the error message or not. compiler/add_class.m: compiler/add_clause.m: compiler/add_foreign_enum.m: compiler/add_foreign_proc.m: compiler/add_mode.m: compiler/add_mutable_aux_preds.m: compiler/add_pragma.m: compiler/add_pragma_tabling.m: compiler/add_pred.m: compiler/add_type.m: compiler/check_for_missing_type_defns.m: compiler/check_promise.m: compiler/check_raw_comp_unit.m: compiler/check_typeclass.m: compiler/det_report.m: compiler/equiv_type.m: compiler/format_call.m: compiler/hlds_error_util.m: compiler/inst_check.m: compiler/introduce_parallelism.m: compiler/make_hlds_error.m: compiler/make_hlds_passes.m: compiler/make_tags.m: compiler/mercury_compile_main.m: compiler/mode_errors.m: compiler/modes.m: compiler/module_qual.qual_errors.m: compiler/modules.m: compiler/oisu_check.m: compiler/parse_inst_mode_defn.m: compiler/parse_item.m: compiler/parse_module.m: compiler/parse_pragma.m: compiler/parse_type_defn.m: compiler/polymorphism.m: compiler/post_term_analysis.m: compiler/prog_out.m: compiler/recompilation.check.m: compiler/resolve_unify_functor.m: compiler/split_parse_tree_src.m: compiler/type_constraints.m: compiler/typecheck_errors.m: compiler/unused_args.m: compiler/unused_imports.m: Conform to the change above. For sym_name references for which the module qualifier is obvious (usually because it *has* to be the module being compiled), change the reference to the variant that omits that qualifier; otherwise, keep the qualifier. In a few places, improve the wording of an error message. tests/invalid/bad_instance.err_exp: tests/invalid/bug17.err_exp: tests/invalid/builtin_int.err_exp: tests/invalid/foreign_purity_mismatch.err_exp: tests/invalid/foreign_type_visibility.err_exp: tests/invalid/fp_dup_bug.err_exp: tests/invalid/fundeps_vars.err_exp: tests/invalid/impl_def_literal_syntax.err_exp: tests/invalid/inline_conflict.err_exp: tests/invalid/inst_list_dup.err_exp: tests/invalid/instance_no_type.err_exp: tests/invalid/invalid_typeclass.err_exp: tests/invalid/missing_interface_import.err_exp: tests/invalid/missing_interface_import2.err_exp: tests/invalid/oisu_check_semantic_errors.err_exp: tests/invalid/tc_err1.err_exp: tests/invalid/tc_err2.err_exp: tests/invalid/transitive_import.err_exp: tests/invalid/type_with_no_defn.err_exp: tests/invalid/typeclass_bogus_method.err_exp: tests/invalid/typeclass_missing_mode_2.err_exp: tests/invalid/typeclass_test_10.err_exp: tests/invalid/typeclass_test_3.err_exp: tests/invalid/typeclass_test_4.err_exp: tests/invalid/typeclass_test_5.err_exp: tests/invalid/typeclass_test_9.err_exp: tests/invalid/types2.err_exp: tests/invalid/undef_inst.err_exp: tests/invalid/undef_mode.err_exp: tests/invalid/undef_mode_and_no_clauses.err_exp: tests/invalid/undef_type.err_exp: tests/invalid/undef_type_mod_qual.err_exp: tests/invalid/uu_type.err_exp: tests/invalid/where_direct_arg.err_exp: tests/invalid/where_direct_arg2.err_exp: tests/invalid/wrong_type_arity.err_exp: tests/recompilation/add_type_re.err_exp.2: tests/recompilation/field_r.err_exp.2: tests/recompilation/remove_type_re.err_exp.2: tests/warnings/inst_with_no_type.exp: Expect the updated versions of error messages.	2017-04-01 20:20:57 +11:00
Zoltan Somogyi	0821b301f2	Require that types/insts/modes in interfaces be defined in the interface. ... compiler/module_qual.m: The interface of a module A contains items (e.g. predicate declarations) that refer to entities such as types, insts, modes etc. They may refer to those entities if (a) they are defined in the interface of module A, (b) in a parent module of module A, or (c) if they are imported from another module, module B, which is imported into module A in the interface of module A. The old algorithm that attempted to enforce this requirement had a basic design fault: it based the decision as to whether the use of an entity in the interface was legal solely on the name of the module that defined that entity. This correctly implements tests (b) and (c), but it does not even attempt to implement the interface test part of (a). It therefore allowed exported items to refer to nonexported entities. This diff changes the whole design approach to the test. Instead of keeping a list of modules *all* of whose entities may be used in the interface of the current module, record for *every* entity whether it may be used in the interface. Set the permissions differently in the interface and implementation sections of the current module. Improve the formatting of the ambiguity error message. NEWS: Announce the stricter enforcement of the documented language rules, in a new section for potentially compatibility-breaking changes. compiler/check_typeclass.m: Delete a test for a special case of the situation that module_qual.m now tests for. If this problem occurs, module_qual.m will pick it up, and check_typeclass.m will never even be invoked, so this copy of the test can never succeed. library/hash_table.m: Fix code that violated the language rules: we export a type that includes another type, but didn't export the second type. We now do. browser/declarative_analyser.m: browser/declarative_edt.m: compiler/coverage_profiling.m: Fix code that violated the language rules. We used to export predicates and functions whose argument types included nonexported types. As it happens, none of those predicates and functions actually need to be exported, so keep them private. In coverage_profiling.m, don't abstract export a type that is not used outside the module, and give a function a name that doesn't clash with a type name. tests/invalid/bug17.{m,err_exp}: A new test case to test the error message we get if the module interface refers to a nonexported type. tests/invalid/bad_instance.err_exp: This test case used to get two kinds of errors, one of which was the illegal use of nonexported type in an exported abstract instance declaration. We now discover this error earlier, and stop after we do so. Update the expected error message. tests/invalid/bad_instance2.{m,err_exp}: New test case: a modified copy of bad_instance.m, testing the other kind of error originally tested by bad_instance.m. tests/invalid/instance_no_type.err_exp: Update the expected error message. tests/invalid/Mmakefile: Enable the new test cases. tests/benchmarks/query.m: tests/hard_coded/unused_float_box_test.m: tests/valid/bug300.m: tests/valid/deforest_bug.m: tests/valid/higher_order4.m: tests/valid/lambda_recompute.m: tests/valid/mert.m: tests/valid/reuse_static.m: tests/valid/switch_detection_bug2.m: tests/valid/time_yaowl.m: tests/warnings/unused_args_test.m: Fix code that violated the language rules, typically by exporting the type that previously, we illegally used in the module interface. tests/recompilation/add_type_re.err_exp.2: Expect the updated ambiguity error message.	2015-11-11 14:28:57 +11:00